jenkins-bot has submitted this change and it was merged.
Change subject: Remove experiment code for moduleStorage
......................................................................
Remove experiment code for moduleStorage
This reverts changes I51cfd5637 and Id2835eca4. We got all the data we needed.
Results (and, hopefully, the full dataset) will be publicized within two weeks.
Bug: 56397
Change-Id: Id39d4457a9b21c4e53e976cd3995c910a7d7031b
---
M resources/mediawiki/mediawiki.js
1 file changed, 3 insertions(+), 38 deletions(-)
Approvals:
Anomie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js
index 8a8215d..724ca5e 100644
--- a/resources/mediawiki/mediawiki.js
+++ b/resources/mediawiki/mediawiki.js
@@ -1749,38 +1749,6 @@
// Cache hit stats
stats: { hits: 0, misses: 0, expired: 0
},
- // Experiment data
- experiment: ( function () {
- var start = ( new Date()
).getTime(), id = 0, seed = 0;
-
- try {
- id = JSON.parse(
localStorage.getItem( 'moduleStorageExperiment' ) );
- if ( typeof id !==
'number' ) {
- id =
Math.floor( Math.random() * Math.random() * 1e16 );
-
localStorage.setItem( 'moduleStorageExperiment', id );
- }
- seed = id % 2000;
- } catch ( e ) {}
-
- return {
- // Unique identifier
for this browser. This allows us to group all
- // datapoints generated
by a particular browser, which in turn allows us
- // to see how the
initial load compares to subsequent page loads.
- id: id,
-
- // Group assignment may
be 0 (not in experiment), 1 (control group), or 2
- // (experimental
group). Browsers that don't implement all the prerequisite APIs
- // (JSON and Web
Storage) are ineligible. Eligible browsers have a 0.1% chance
- // of being included in
the experiment, in which case they are equally likely to
- // be assigned to
either the experimental or control group.
- group: seed === 1 ? 1 :
( seed === 2 ? 2 : 0 ),
-
- // Assess module
storage performance by measuring the time between this
- // reference point and
the window load event.
- start: start
- };
- }() ),
-
/**
* Construct a JSON-serializable object
representing the content of the store.
* @return {Object} Module store
contents.
@@ -1838,12 +1806,9 @@
return;
}
- if (
- // We're in debug mode
- mw.config.get( 'debug'
) ||
- // Module storage is
neither enabled by default, nor enabled for this user's group.
- !( mw.config.get(
'wgResourceLoaderStorageEnabled' ) || mw.loader.store.experiment.group === 2 )
- ) {
+ if ( !mw.config.get(
'wgResourceLoaderStorageEnabled' ) || mw.config.get( 'debug' ) ) {
+ // Disabled by
configuration, or because debug mode is set.
+ mw.loader.store.enabled
= false;
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/97482
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id39d4457a9b21c4e53e976cd3995c910a7d7031b
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
