Milimetric has uploaded a new change for review.
https://gerrit.wikimedia.org/r/97850
Change subject: Teresa Tso found some bugs
......................................................................
Teresa Tso found some bugs
Change-Id: Ic20aa291ad979fd556f1baa3529887773d5e4b23
---
M tests/test_models/test_multi_project_metric_report.py
M wikimetrics/database.py
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/wikimetrics
refs/changes/50/97850/1
diff --git a/tests/test_models/test_multi_project_metric_report.py
b/tests/test_models/test_multi_project_metric_report.py
index c7580e9..0d7def6 100644
--- a/tests/test_models/test_multi_project_metric_report.py
+++ b/tests/test_models/test_multi_project_metric_report.py
@@ -43,7 +43,7 @@
start_date='2013-05-01 00:00:00',
end_date='2013-09-01 00:00:00',
)
- mr = MultiProjectMetricReport(self.cohort, metric, 'enwiki')
+ mr = MultiProjectMetricReport(self.cohort, metric)
finished = mr.finish([
{
@@ -64,6 +64,6 @@
start_date='2013-05-01 00:00:00',
end_date='2013-09-01 00:00:00',
)
- mr = MultiProjectMetricReport(self.cohort, metric, 'enwiki')
+ mr = MultiProjectMetricReport(self.cohort, metric)
assert_true(str(mr).find('MultiProjectMetricReport') >= 0)
diff --git a/wikimetrics/database.py b/wikimetrics/database.py
index c57d24d..fb1d92b 100644
--- a/wikimetrics/database.py
+++ b/wikimetrics/database.py
@@ -89,7 +89,7 @@
Returns:
new sqlalchemy session open to the wikimetrics database
"""
- if not self.wikimetrics_engine:
+ if not self.wikimetrics_sessionmaker:
self.wikimetrics_engine = create_engine(
self.config['WIKIMETRICS_ENGINE_URL'],
echo=self.config['SQL_ECHO'],
--
To view, visit https://gerrit.wikimedia.org/r/97850
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic20aa291ad979fd556f1baa3529887773d5e4b23
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
