jenkins-bot has submitted this change and it was merged.
Change subject: Fix notices on undefined $fileHandle and $res
......................................................................
Fix notices on undefined $fileHandle and $res
Change-Id: If9f37549af85df0a418dbd12a7793e5a45868f61
---
M maintenance/cdb.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/cdb.php b/maintenance/cdb.php
index bda64f3..1772b5f 100644
--- a/maintenance/cdb.php
+++ b/maintenance/cdb.php
@@ -52,7 +52,7 @@
$bad = false;
$showhelp = false;
$quit = false;
- static $fileHandle;
+ static $fileHandle = false;
$line = Maintenance::readconsole();
if ( $line === false ) {
@@ -98,6 +98,7 @@
$res = $fileHandle->get( $args[0] );
} catch ( CdbException $e ) {
print "Unable to read key from file\n";
+ break;
}
if ( $res === false ) {
print "No such key/value pair\n";
--
To view, visit https://gerrit.wikimedia.org/r/97930
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9f37549af85df0a418dbd12a7793e5a45868f61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
