Kaldari has submitted this change and it was merged. Change subject: LivePreview: coding conventions and overall code prettiness ......................................................................
LivePreview: coding conventions and overall code prettiness There are no functionality changes; some code has been moved around, some variables were renamed, some whitespace fixed, some comments updated. Slightly non-trivial changes: * use .animate instead of .fadeTo (see comment in code for explanation) * move loading diff styles out of the if (RL will take care of it) Change-Id: I57e2fc0b090b6cbbcc15a445ac65bab860fbcae9 --- M skins/common/preview.js 1 file changed, 57 insertions(+), 64 deletions(-) Approvals: Kaldari: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/22303 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57e2fc0b090b6cbbcc15a445ac65bab860fbcae9 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: MarkTraceur <[email protected]> Gerrit-Reviewer: Matmarex <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
