Jcf2000 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/98029
Change subject: Addressed previous issures: Changed comments and improved
retain function
......................................................................
Addressed previous issures: Changed comments and improved retain function
Change-Id: I82f3997efe37f1d7238f343e7a0ddb9dd3df04a0
---
M repo/includes/specials/SpecialModifyEntity.php
M repo/includes/specials/SpecialSetSiteLink.php
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/29/98029/1
diff --git a/repo/includes/specials/SpecialModifyEntity.php
b/repo/includes/specials/SpecialModifyEntity.php
index 412dd8f..fba0a74 100644
--- a/repo/includes/specials/SpecialModifyEntity.php
+++ b/repo/includes/specials/SpecialModifyEntity.php
@@ -265,7 +265,7 @@
)
. Html::input(
'id',
- $id,
+ $this->getRequest()->getVal( 'id' ),
'text',
array(
'class' => 'wb-input',
diff --git a/repo/includes/specials/SpecialSetSiteLink.php
b/repo/includes/specials/SpecialSetSiteLink.php
index 8038cdf..bb79af7 100644
--- a/repo/includes/specials/SpecialSetSiteLink.php
+++ b/repo/includes/specials/SpecialSetSiteLink.php
@@ -164,9 +164,10 @@
if ( $this->page === null ) {
$this->page = $this->getSiteLink( $this->entityContent,
$this->site );
}
+ //Retain form input on Special:SetSiteLink in case of an error
$pageinput = Html::input(
'page',
- $this->page,
+ $this->getRequest()->getVal( 'page' ),
'text',
array(
'class' => 'wb-input wb-input-text',
@@ -208,9 +209,10 @@
),
$this->msg( 'wikibase-setsitelink-site'
)->text()
)
+ //Retain form input on Special:SetSiteLink in case of
an error
. Html::input(
'site',
- $this->site,
+ $this->getRequest()->getVal( 'site' ),
'text',
array(
'class' => 'wb-input',
--
To view, visit https://gerrit.wikimedia.org/r/98029
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82f3997efe37f1d7238f343e7a0ddb9dd3df04a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jcf2000 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
