Aklapper has uploaded a new change for review.
https://gerrit.wikimedia.org/r/98031
Change subject: [4.4] Sync MoreBugUrl extension with upstream
......................................................................
[4.4] Sync MoreBugUrl extension with upstream
DO NOT COMMIT until Bugzilla has been upgraded to 4.4.
Change-Id: I7ea496ca167f91faf7424ec852f13a7ba99d0f26
---
M extensions/MoreBugUrl/lib/GetSatisfaction.pm
M extensions/MoreBugUrl/lib/PHP.pm
M extensions/MoreBugUrl/lib/RT.pm
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/bugzilla/modifications
refs/changes/31/98031/1
diff --git a/extensions/MoreBugUrl/lib/GetSatisfaction.pm
b/extensions/MoreBugUrl/lib/GetSatisfaction.pm
index 4c077b1..75d5ece 100644
--- a/extensions/MoreBugUrl/lib/GetSatisfaction.pm
+++ b/extensions/MoreBugUrl/lib/GetSatisfaction.pm
@@ -20,7 +20,7 @@
# GetSatisfaction URLs only have one form:
# http(s)://getsatisfaction.com/PROJECT_NAME/topics/TOPIC_NAME
- return ($uri->authority =~ /^getsatisfaction.com$/i
+ return (lc($uri->authority) eq 'getsatisfaction.com'
and $uri->path =~ m|^/[^/]+/topics/[^/]+$|) ? 1 : 0;
}
diff --git a/extensions/MoreBugUrl/lib/PHP.pm b/extensions/MoreBugUrl/lib/PHP.pm
index 1521cae..ea090e8 100644
--- a/extensions/MoreBugUrl/lib/PHP.pm
+++ b/extensions/MoreBugUrl/lib/PHP.pm
@@ -20,8 +20,8 @@
# PHP Bug URLs have only one form:
# https://bugs.php.net/bug.php?id=1234
- return ($uri->authority =~ /^bugs.php.net$/i
- and $uri->path =~ m|/bug.php$|
+ return (lc($uri->authority) eq 'bugs.php.net'
+ and $uri->path =~ m|/bug\.php$|
and $uri->query_param('id') =~ /^\d+$/) ? 1 : 0;
}
diff --git a/extensions/MoreBugUrl/lib/RT.pm b/extensions/MoreBugUrl/lib/RT.pm
index 7244568..a1ca6fd 100644
--- a/extensions/MoreBugUrl/lib/RT.pm
+++ b/extensions/MoreBugUrl/lib/RT.pm
@@ -21,7 +21,7 @@
# RT URLs can look like various things:
# http://example.com/rt/Ticket/Display.html?id=1234
# https://example.com/Public/Bug/Display.html?id=1234
- return ($uri->path =~ m|/Display.html$|
+ return ($uri->path =~ m|/Display\.html$|
and $uri->query_param('id') =~ /^\d+$/) ? 1 : 0;
}
--
To view, visit https://gerrit.wikimedia.org/r/98031
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ea496ca167f91faf7424ec852f13a7ba99d0f26
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/bugzilla/modifications
Gerrit-Branch: master
Gerrit-Owner: Aklapper <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
