jenkins-bot has submitted this change and it was merged.
Change subject: Prefer double-quoted strings in Ruby code
......................................................................
Prefer double-quoted strings in Ruby code
Bug: 57597
Change-Id: I12b96411abe255130e156e20fa41eef558460196
---
M tests/browser/features/step_definitions/cog_sidebar_user_steps.rb
M tests/browser/features/step_definitions/common_steps.rb
M tests/browser/features/step_definitions/font_selection_steps.rb
M tests/browser/features/step_definitions/ime_steps.rb
M
tests/browser/features/step_definitions/live_preview_of_display_language_steps.rb
M tests/browser/features/step_definitions/panel_steps.rb
M tests/browser/features/step_definitions/persistent_settings_steps.rb
M tests/browser/features/step_definitions/textarea_font_steps.rb
M tests/browser/features/support/env.rb
M tests/browser/features/support/hooks.rb
M tests/browser/features/support/modules/interlanguage_module.rb
M tests/browser/features/support/modules/language_module.rb
M tests/browser/features/support/modules/url_module.rb
M tests/browser/features/support/pages/edit_page.rb
M tests/browser/features/support/pages/ime_page.rb
M tests/browser/features/support/pages/interlanguage_page.rb
M tests/browser/features/support/pages/login_page.rb
M tests/browser/features/support/pages/main_page.rb
M tests/browser/features/support/pages/no_interlanguage_page.rb
M tests/browser/features/support/pages/panel_page.rb
M tests/browser/features/support/pages/preferences_page.rb
M tests/browser/features/support/pages/random_page.rb
M tests/browser/features/support/pages/reset_preferences.rb
23 files changed, 138 insertions(+), 138 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/cog_sidebar_user_steps.rb
b/tests/browser/features/step_definitions/cog_sidebar_user_steps.rb
index fbc1145..db01cb4 100644
--- a/tests/browser/features/step_definitions/cog_sidebar_user_steps.rb
+++ b/tests/browser/features/step_definitions/cog_sidebar_user_steps.rb
@@ -16,15 +16,15 @@
end
Given(/^I navigate to the anonymous Language Settings panel$/) do
- step 'I am on a page with interlanguage links'
- step 'I click the cog icon by Languages in the sidebar'
- step 'I see the logged out language settings panel'
+ step "I am on a page with interlanguage links"
+ step "I click the cog icon by Languages in the sidebar"
+ step "I see the logged out language settings panel"
end
Given(/^I navigate to the Language Settings panel$/) do
- step 'I am on a page with interlanguage links'
- step 'I click the cog icon by Languages in the sidebar'
- step 'I see the logged in language settings panel'
+ step "I am on a page with interlanguage links"
+ step "I click the cog icon by Languages in the sidebar"
+ step "I see the logged in language settings panel"
end
When(/^I click Cancel$/) do
@@ -81,7 +81,7 @@
end
Then(/^I see Common Languages$/) do
- on(InterlanguagePage).language_list.should match Regexp.escape('Common
languages')
+ on(InterlanguagePage).language_list.should match Regexp.escape("Common
languages")
end
Then(/^I see Language Search$/) do
@@ -106,19 +106,19 @@
Then(/^I see Worldwide$/) do
on(InterlanguagePage) do |page|
- page.language_list.should match Regexp.escape('Worldwide')
+ page.language_list.should match Regexp.escape("Worldwide")
page.english_link_element.should be_visible
end
end
Then(/^I click the cog icon to open language settings again$/) do
- step 'I click the cog icon by Languages in the sidebar'
- step 'I see the logged out language settings panel'
+ step "I click the cog icon by Languages in the sidebar"
+ step "I see the logged out language settings panel"
end
Then(/^the cog icon brings up Language Settings again$/) do
- step 'I click the cog icon by Languages in the sidebar'
- step 'I see the Language Settings panel'
+ step "I click the cog icon by Languages in the sidebar"
+ step "I see the Language Settings panel"
end
Then(/^I should see the How to use link near the Malayalam transliteration
item$/) do
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index 27685d0..70c10cf 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -6,7 +6,7 @@
end
Given(/^I am logged in$/) do
- visit(LoginPage).login_with(ENV['MEDIAWIKI_USER'],
ENV['MEDIAWIKI_PASSWORD'])
+ visit(LoginPage).login_with(ENV["MEDIAWIKI_USER"],
ENV["MEDIAWIKI_PASSWORD"])
end
Given(/^I set "(.*?)" as the interface language$/) do |language|
@@ -23,5 +23,5 @@
Then(/^my interface language is "(.*?)"$/) do |language|
code = on(PanelPage).language_to_code(language)
- on(PanelPage).interface_element.attribute('lang').should == code
+ on(PanelPage).interface_element.attribute("lang").should == code
end
diff --git a/tests/browser/features/step_definitions/font_selection_steps.rb
b/tests/browser/features/step_definitions/font_selection_steps.rb
index 92a8ab7..daca9f7 100644
--- a/tests/browser/features/step_definitions/font_selection_steps.rb
+++ b/tests/browser/features/step_definitions/font_selection_steps.rb
@@ -3,7 +3,7 @@
end
Then(/^the active content font must be the same as font prior to the
preview$/) do
- pending('bug #56081') do
+ pending("bug #56081") do
on(PanelPage).content_font.should == @original_content_font
end
end
@@ -13,8 +13,8 @@
end
Then(/^the selected content font must be "(.*?)"$/) do |font|
- step 'I open Display panel of language settings'
- step 'I open Fonts panel of language settings'
+ step "I open Display panel of language settings"
+ step "I open Fonts panel of language settings"
on(PanelPage).selected_content_font.should == font
end
diff --git a/tests/browser/features/step_definitions/ime_steps.rb
b/tests/browser/features/step_definitions/ime_steps.rb
index 732253a..2b6b64e 100644
--- a/tests/browser/features/step_definitions/ime_steps.rb
+++ b/tests/browser/features/step_definitions/ime_steps.rb
@@ -15,7 +15,7 @@
end
When(/^I open the input method menu$/) do
- step 'I click on an input box'
+ step "I click on an input box"
on(IMEPage).input_method_element.when_present.click
end
@@ -51,7 +51,7 @@
end
When(/^I press Control-M$/) do
- on(IMEPage).search_input_element.send_keys [:control, 'm']
+ on(IMEPage).search_input_element.send_keys [:control, "m"]
end
When(/^I go to another random page$/) do
@@ -60,7 +60,7 @@
Then(/^in it there must be an element with Malayalam text$/) do
# 'input_method_enabled' alone only returns []
- on(IMEPage).input_method_enabled_element.text.should == 'ഇൻസ്ക്രിപ്റ്റ് 2'
+ on(IMEPage).input_method_enabled_element.text.should == "ഇൻസ്ക്രിപ്റ്റ് 2"
end
Given(/^I visit a random page with (.+) skin and (.+) as the interface
language$/) do |skin, language|
diff --git
a/tests/browser/features/step_definitions/live_preview_of_display_language_steps.rb
b/tests/browser/features/step_definitions/live_preview_of_display_language_steps.rb
index 53f869f..b6e0ac9 100644
---
a/tests/browser/features/step_definitions/live_preview_of_display_language_steps.rb
+++
b/tests/browser/features/step_definitions/live_preview_of_display_language_steps.rb
@@ -1,13 +1,13 @@
When(/^I set English font to System$/) do
- on(PanelPage).select_font_for_content = 'System font'
+ on(PanelPage).select_font_for_content = "System font"
end
And(/^I set English font to OpenDyslexic$/) do
- on(PanelPage).select_font_for_content = 'OpenDyslexic'
+ on(PanelPage).select_font_for_content = "OpenDyslexic"
end
Then(/^the selected content font must be OpenDyslexic$/) do
- on(PanelPage).select_font_for_content.should == 'OpenDyslexic'
+ on(PanelPage).select_font_for_content.should == "OpenDyslexic"
end
And(/^I select a language different than English for display language$/) do
@@ -20,5 +20,5 @@
Then(/^I should see the text in the language panel in (.+?)$/) do |language|
code = on(PanelPage).language_to_code(language)
- on(PanelPage).uls_display_settings_element.attribute('lang').should ==
code
+ on(PanelPage).uls_display_settings_element.attribute("lang").should ==
code
end
diff --git a/tests/browser/features/step_definitions/panel_steps.rb
b/tests/browser/features/step_definitions/panel_steps.rb
index 927d2ef..3c0433f 100644
--- a/tests/browser/features/step_definitions/panel_steps.rb
+++ b/tests/browser/features/step_definitions/panel_steps.rb
@@ -65,7 +65,7 @@
end
Then(/^the panel is in English/) do
- on(PanelPage).panel_language_element.text.should == 'Language'
+ on(PanelPage).panel_language_element.text.should == "Language"
end
When(/^I switch to "Input" panel of language settings/) do
diff --git
a/tests/browser/features/step_definitions/persistent_settings_steps.rb
b/tests/browser/features/step_definitions/persistent_settings_steps.rb
index a91a982..2014fbb 100644
--- a/tests/browser/features/step_definitions/persistent_settings_steps.rb
+++ b/tests/browser/features/step_definitions/persistent_settings_steps.rb
@@ -1,14 +1,14 @@
Then(/^the selected interface font must be (.*?)$/) do |font|
- step 'I open the Universal Language Selector'
- step 'I open Display panel of language settings'
- step 'I open Fonts panel of language settings'
+ step "I open the Universal Language Selector"
+ step "I open Display panel of language settings"
+ step "I open Fonts panel of language settings"
on(PanelPage).selected_interface_font.should == font
end
Then(/^the selected input method for Malayalam is ml-inscript2$/) do
- step 'I click on an input box'
- step 'I should see the input method indicator'
- step 'in it there must be an element with Malayalam text'
+ step "I click on an input box"
+ step "I should see the input method indicator"
+ step "in it there must be an element with Malayalam text"
end
When(/^I select the ml-inscript2 input method in the panel$/) do
diff --git a/tests/browser/features/step_definitions/textarea_font_steps.rb
b/tests/browser/features/step_definitions/textarea_font_steps.rb
index bb8f1f2..0904ef8 100644
--- a/tests/browser/features/step_definitions/textarea_font_steps.rb
+++ b/tests/browser/features/step_definitions/textarea_font_steps.rb
@@ -15,13 +15,13 @@
end
When(/^I select (.*?) font for the content language$/) do |font|
- step 'I open the Universal Language Selector'
- step 'I open Display panel of language settings'
- step 'I open Fonts panel of language settings'
+ step "I open the Universal Language Selector"
+ step "I open Display panel of language settings"
+ step "I open Fonts panel of language settings"
pending("Bug 56885") do
step "I select #{font} font for the content language for the
live preview"
end
- step 'I apply the changes'
+ step "I apply the changes"
end
Then(/^I should see the edit area text being displayed using "(.*?)" font$/)
do |font|
diff --git a/tests/browser/features/support/env.rb
b/tests/browser/features/support/env.rb
index b97a64e..ae467bf 100644
--- a/tests/browser/features/support/env.rb
+++ b/tests/browser/features/support/env.rb
@@ -1,2 +1,2 @@
-require_relative 'hooks'
-require 'mediawiki/selenium'
+require_relative "hooks"
+require "mediawiki/selenium"
diff --git a/tests/browser/features/support/hooks.rb
b/tests/browser/features/support/hooks.rb
index e806451..192c693 100644
--- a/tests/browser/features/support/hooks.rb
+++ b/tests/browser/features/support/hooks.rb
@@ -1,8 +1,8 @@
-Before('@language') do |scenario|
+Before("@language") do |scenario|
@language = true
@scenario = scenario
end
-After('@reset-preferences-after') do |scenario|
+After("@reset-preferences-after") do |scenario|
visit(ResetPreferencesPage).submit_element.click if @browser.exist?
end
diff --git a/tests/browser/features/support/modules/interlanguage_module.rb
b/tests/browser/features/support/modules/interlanguage_module.rb
index 5c9685b..5d46e5b 100644
--- a/tests/browser/features/support/modules/interlanguage_module.rb
+++ b/tests/browser/features/support/modules/interlanguage_module.rb
@@ -4,20 +4,20 @@
module InterlanguagePageModule
include PageObject
- a(:add_links, id: 'wbc-linkToItem-link')
- a(:back_to_display, text: 'Back to display settings')
- a(:back_to_input, text: 'Back to input settings')
- span(:cog, class: 'uls-settings-trigger')
- button(:ellipsis_button, class: 'uls-more-languages button')
- a(:english_link, text: 'English')
- a(:hindi_link, text: 'हिन्दी')
- div(:input_settings, id: 'input-settings-block')
- div(:language_list, class: 'row uls-language-list lcd')
- text_field(:language_search, id: 'languagefilter')
- button(:non_default_language, class: 'button uls-language-button', index: 1)
- a(:talk, text: 'Discussion')
- span(:x, id: 'languagesettings-close')
- a(:how_to_use_ml_transliteration, href:
'https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:UniversalLanguageSelector/Input_methods/ml-transliteration')
- a(:edit_link, css: '#ca-edit a')
- a(:interlang_link, css: '#p-lang li.interlanguage-link')
+ a(:add_links, id: "wbc-linkToItem-link")
+ a(:back_to_display, text: "Back to display settings")
+ a(:back_to_input, text: "Back to input settings")
+ span(:cog, class: "uls-settings-trigger")
+ button(:ellipsis_button, class: "uls-more-languages button")
+ a(:english_link, text: "English")
+ a(:hindi_link, text: "हिन्दी")
+ div(:input_settings, id: "input-settings-block")
+ div(:language_list, class: "row uls-language-list lcd")
+ text_field(:language_search, id: "languagefilter")
+ button(:non_default_language, class: "button uls-language-button", index: 1)
+ a(:talk, text: "Discussion")
+ span(:x, id: "languagesettings-close")
+ a(:how_to_use_ml_transliteration, href:
"https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:UniversalLanguageSelector/Input_methods/ml-transliteration";)
+ a(:edit_link, css: "#ca-edit a")
+ a(:interlang_link, css: "#p-lang ul")
end
diff --git a/tests/browser/features/support/modules/language_module.rb
b/tests/browser/features/support/modules/language_module.rb
index b385260..5da34fb 100644
--- a/tests/browser/features/support/modules/language_module.rb
+++ b/tests/browser/features/support/modules/language_module.rb
@@ -3,16 +3,16 @@
def language_to_code(language)
case language
- when 'German'
- 'de'
- when 'English'
- 'en'
- when 'Finnish'
- 'fi'
- when 'Hebrew'
- 'he'
- when 'Hindi'
- 'hi'
+ when "German"
+ "de"
+ when "English"
+ "en"
+ when "Finnish"
+ "fi"
+ when "Hebrew"
+ "he"
+ when "Hindi"
+ "hi"
else
pending
end
diff --git a/tests/browser/features/support/modules/url_module.rb
b/tests/browser/features/support/modules/url_module.rb
index 6268546..1dd1856 100644
--- a/tests/browser/features/support/modules/url_module.rb
+++ b/tests/browser/features/support/modules/url_module.rb
@@ -1,9 +1,9 @@
module URL
def self.url(name)
- if ENV['MEDIAWIKI_URL']
- mediawiki_url = ENV['MEDIAWIKI_URL']
+ if ENV["MEDIAWIKI_URL"]
+ mediawiki_url = ENV["MEDIAWIKI_URL"]
else
- mediawiki_url = 'http://en.wikipedia.beta.wmflabs.org/wiki/'
+ mediawiki_url = "http://en.wikipedia.beta.wmflabs.org/wiki/";
end
"#{mediawiki_url}#{name}"
end
diff --git a/tests/browser/features/support/pages/edit_page.rb
b/tests/browser/features/support/pages/edit_page.rb
index d62e3de..43ce0c5 100644
--- a/tests/browser/features/support/pages/edit_page.rb
+++ b/tests/browser/features/support/pages/edit_page.rb
@@ -1,5 +1,5 @@
class EditPage
include PageObject
- textarea(:editarea, id: 'wpTextbox1')
+ textarea(:editarea, id: "wpTextbox1")
end
diff --git a/tests/browser/features/support/pages/ime_page.rb
b/tests/browser/features/support/pages/ime_page.rb
index b126f8b..1e5cda2 100644
--- a/tests/browser/features/support/pages/ime_page.rb
+++ b/tests/browser/features/support/pages/ime_page.rb
@@ -3,17 +3,17 @@
include LanguageModule
include URL
- page_url URL.url('?<%=params[:extra]%>')
+ page_url URL.url("?<%=params[:extra]%>")
- div(:input_method, class: 'imeselector imeselector-toggle')
- a(:input_method_enabled, class: 'ime-name imeselector-toggle')
- h3(:input_method_ime_list_title, class: 'ime-list-title')
- ul(:input_method_language_list, class: 'ime-language-list')
- div(:input_method_selector_menu, class: 'imeselector-menu')
- text_field(:language_filter, id: 'languagefilter')
- li(:malayalam_inscript2, data_ime_inputmethod: 'ml-inscript2')
- a(:more_languages, class: 'ime-selector-more-languages')
- text_field(:search_input, id: 'searchInput')
+ div(:input_method, class: "imeselector imeselector-toggle")
+ a(:input_method_enabled, class: "ime-name imeselector-toggle")
+ h3(:input_method_ime_list_title, class: "ime-list-title")
+ ul(:input_method_language_list, class: "ime-language-list")
+ div(:input_method_selector_menu, class: "imeselector-menu")
+ text_field(:language_filter, id: "languagefilter")
+ li(:malayalam_inscript2, data_ime_inputmethod: "ml-inscript2")
+ a(:more_languages, class: "ime-selector-more-languages")
+ text_field(:search_input, id: "searchInput")
def ime_input_method_menu_onscreen?
@browser.execute_script( "
diff --git a/tests/browser/features/support/pages/interlanguage_page.rb
b/tests/browser/features/support/pages/interlanguage_page.rb
index 7e3e451..e437c71 100644
--- a/tests/browser/features/support/pages/interlanguage_page.rb
+++ b/tests/browser/features/support/pages/interlanguage_page.rb
@@ -4,7 +4,7 @@
include URL
def self.url
- URL.url('Boleyn_family')
+ URL.url("Boleyn_family")
end
page_url url
diff --git a/tests/browser/features/support/pages/login_page.rb
b/tests/browser/features/support/pages/login_page.rb
index 6890050..e4179e4 100644
--- a/tests/browser/features/support/pages/login_page.rb
+++ b/tests/browser/features/support/pages/login_page.rb
@@ -2,18 +2,18 @@
include PageObject
include URL
- page_url URL.url('Special:UserLogin')
+ page_url URL.url("Special:UserLogin")
- div(:feedback, class: 'errorbox')
- button(:login, id: 'wpLoginAttempt')
- text_field(:password, id: 'wpPassword1')
- a(:password_strength, text: 'password strength')
- a(:phishing, text: 'phishing')
- text_field(:username, id: 'wpName1')
+ div(:feedback, class: "errorbox")
+ button(:login, id: "wpLoginAttempt")
+ text_field(:password, id: "wpPassword1")
+ a(:password_strength, text: "password strength")
+ a(:phishing, text: "phishing")
+ text_field(:username, id: "wpName1")
a(:username_displayed, title: /Your user page/)
def logged_in_as_element
- @browser.div(id: 'mw-content-text').p.b
+ @browser.div(id: "mw-content-text").p.b
end
def login_with(username, password)
self.username = username
diff --git a/tests/browser/features/support/pages/main_page.rb
b/tests/browser/features/support/pages/main_page.rb
index fce8e55..6472beb 100644
--- a/tests/browser/features/support/pages/main_page.rb
+++ b/tests/browser/features/support/pages/main_page.rb
@@ -2,10 +2,10 @@
include PageObject
include URL
- page_url URL.url('Main_Page')
+ page_url URL.url("Main_Page")
def non_interlanguage_links_use_autonym_font?
- @browser.elements(css: '#p-lang
li:not(.interlanguage-link)').collect do |element|
+ @browser.elements(css: "#p-lang
li:not(.interlanguage-link)").collect do |element|
element.style("font-family")
end.to_s.match(/Autonym/) != nil
end
diff --git a/tests/browser/features/support/pages/no_interlanguage_page.rb
b/tests/browser/features/support/pages/no_interlanguage_page.rb
index 30846ba..76d9d1c 100644
--- a/tests/browser/features/support/pages/no_interlanguage_page.rb
+++ b/tests/browser/features/support/pages/no_interlanguage_page.rb
@@ -3,7 +3,7 @@
include URL
def self.url
- URL.url('Think_Like_a_Cat')
+ URL.url("Think_Like_a_Cat")
end
page_url url
diff --git a/tests/browser/features/support/pages/panel_page.rb
b/tests/browser/features/support/pages/panel_page.rb
index 853ffcc..12f9bbe 100644
--- a/tests/browser/features/support/pages/panel_page.rb
+++ b/tests/browser/features/support/pages/panel_page.rb
@@ -3,58 +3,58 @@
include LanguageModule
include URL
- page_url URL.url('?<%=params[:extra]%>')
+ page_url URL.url("?<%=params[:extra]%>")
- div(:uls, class: 'uls-menu')
- span(:uls_button_close, id: 'uls-close')
+ div(:uls, class: "uls-menu")
+ span(:uls_button_close, id: "uls-close")
- div(:language_settings_dialog, id: 'language-settings-dialog')
- div(:panel_display, id: 'display-settings-block')
- div(:panel_input, id: 'input-settings-block')
- button(:panel_fonts, id: 'uls-display-settings-fonts-tab')
- button(:panel_language, id: 'uls-display-settings-language-tab')
+ div(:language_settings_dialog, id: "language-settings-dialog")
+ div(:panel_display, id: "display-settings-block")
+ div(:panel_input, id: "input-settings-block")
+ button(:panel_fonts, id: "uls-display-settings-fonts-tab")
+ button(:panel_language, id: "uls-display-settings-language-tab")
- div(:panel_side_display, id: 'display-panel-trigger')
- div(:panel_side_input, id: 'input-panel-trigger')
+ div(:panel_side_display, id: "display-panel-trigger")
+ div(:panel_side_input, id: "input-panel-trigger")
- ul(:autonym, class: 'three columns end')
+ ul(:autonym, class: "three columns end")
- span(:panel_button_close, id: 'languagesettings-close')
- button(:panel_button_apply, class: 'uls-settings-apply')
- button(:panel_button_cancel, class: 'uls-settings-cancel')
+ span(:panel_button_close, id: "languagesettings-close")
+ button(:panel_button_apply, class: "uls-settings-apply")
+ button(:panel_button_cancel, class: "uls-settings-cancel")
- button(:panel_disable_input_methods, class: 'uls-input-toggle-button')
- button(:panel_enable_input_methods, class: 'uls-input-toggle-button')
+ button(:panel_disable_input_methods, class: "uls-input-toggle-button")
+ button(:panel_enable_input_methods, class: "uls-input-toggle-button")
- select_list(:panel_content_font_selector, id: 'content-font-selector')
- select_list(:panel_interface_font_selector, id: 'ui-font-selector')
+ select_list(:panel_content_font_selector, id: "content-font-selector")
+ select_list(:panel_interface_font_selector, id: "ui-font-selector")
# TODO: Rename to match convention
- button(:other_language_button, class: 'button uls-language-button',
index: 1)
- button(:default_language_button, css: '.uls-language-button.down')
+ button(:other_language_button, class: "button uls-language-button",
index: 1)
+ button(:default_language_button, css: ".uls-language-button.down")
# Triggers
- span(:trigger_cog, class: 'uls-settings-trigger')
- a(:trigger_personal, class: 'uls-trigger')
+ span(:trigger_cog, class: "uls-settings-trigger")
+ a(:trigger_personal, class: "uls-trigger")
- select(:selected_content_font, id: 'content-font-selector')
- select(:selected_interface_font, id: 'ui-font-selector')
+ select(:selected_content_font, id: "content-font-selector")
+ select(:selected_interface_font, id: "ui-font-selector")
- select(:font_for_content, id: 'content-font-selector')
+ select(:font_for_content, id: "content-font-selector")
- div(:uls_display_settings, class: 'uls-display-settings')
+ div(:uls_display_settings, class: "uls-display-settings")
- radio_button(:ml_inscript2_radio, id: 'ml-inscript2')
+ radio_button(:ml_inscript2_radio, id: "ml-inscript2")
# Is there way to access the html element?
- div(:interface, id: 'footer')
+ div(:interface, id: "footer")
def content_font
- font('#mw-content-text')
+ font("#mw-content-text")
end
def interface_font
- font('body')
+ font("body")
end
def uls_onscreen?
diff --git a/tests/browser/features/support/pages/preferences_page.rb
b/tests/browser/features/support/pages/preferences_page.rb
index 50d26c4..2613988 100644
--- a/tests/browser/features/support/pages/preferences_page.rb
+++ b/tests/browser/features/support/pages/preferences_page.rb
@@ -2,11 +2,11 @@
include PageObject
include URL
- page_url URL.url('Special:Preferences')
+ page_url URL.url("Special:Preferences")
- select(:set_interface_language, id: 'mw-input-wplanguage')
- button(:save, id: 'prefcontrol')
+ select(:set_interface_language, id: "mw-input-wplanguage")
+ button(:save, id: "prefcontrol")
- a(:editing_tab, id: 'preftab-editing')
- select(:editing_font, id: 'mw-input-wpeditfont')
+ a(:editing_tab, id: "preftab-editing")
+ select(:editing_font, id: "mw-input-wpeditfont")
end
diff --git a/tests/browser/features/support/pages/random_page.rb
b/tests/browser/features/support/pages/random_page.rb
index 3373882..a6aac90 100644
--- a/tests/browser/features/support/pages/random_page.rb
+++ b/tests/browser/features/support/pages/random_page.rb
@@ -4,15 +4,15 @@
include PageObject
include URL
- page_url URL.url('Special:Random')
+ page_url URL.url("Special:Random")
- span(:cog, title: 'Language settings')
- a(:create_a_book, text: 'Create a book')
- a(:download_as_pdf, text: 'Download as PDF')
- a(:download_the_file, text: 'Download the file')
- li(:main_page, id: 'n-mainpage-description')
- a(:malayalam_link, title: 'Malayalam')
- a(:print_export, text: 'Print/export')
- a(:printable_version, text: 'Printable version')
- button(:search_button, id: 'searchButton')
+ span(:cog, title: "Language settings")
+ a(:create_a_book, text: "Create a book")
+ a(:download_as_pdf, text: "Download as PDF")
+ a(:download_the_file, text: "Download the file")
+ li(:main_page, id: "n-mainpage-description")
+ a(:malayalam_link, title: "Malayalam")
+ a(:print_export, text: "Print/export")
+ a(:printable_version, text: "Printable version")
+ button(:search_button, id: "searchButton")
end
diff --git a/tests/browser/features/support/pages/reset_preferences.rb
b/tests/browser/features/support/pages/reset_preferences.rb
index dc6640f..37c6726 100644
--- a/tests/browser/features/support/pages/reset_preferences.rb
+++ b/tests/browser/features/support/pages/reset_preferences.rb
@@ -1,7 +1,7 @@
class ResetPreferencesPage
include PageObject
include URL
- page_url URL.url('Special:Preferences/reset')
+ page_url URL.url("Special:Preferences/reset")
- button(:submit, class: 'mw-htmlform-submit')
+ button(:submit, class: "mw-htmlform-submit")
end
--
To view, visit https://gerrit.wikimedia.org/r/97781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12b96411abe255130e156e20fa41eef558460196
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Mayankmadan <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Jhall <[email protected]>
Gerrit-Reviewer: KartikMistry <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
