jenkins-bot has submitted this change and it was merged.
Change subject: Replace weird .select() reimplementation
......................................................................
Replace weird .select() reimplementation
Browsers have had a .select() method on <input>s and <textarea>s
since the dawn of the web.
Change-Id: Ib35415115291086300494ef1c6cb3063cd6b8e94
---
M resources/ext.multimediaViewer/ext.multimediaViewer.js
M resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js
2 files changed, 1 insertion(+), 28 deletions(-)
Approvals:
MarkTraceur: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.multimediaViewer/ext.multimediaViewer.js
b/resources/ext.multimediaViewer/ext.multimediaViewer.js
index c3d2b0e..aef19fb 100755
--- a/resources/ext.multimediaViewer/ext.multimediaViewer.js
+++ b/resources/ext.multimediaViewer/ext.multimediaViewer.js
@@ -739,23 +739,4 @@
} );
mw.MultimediaViewer = MultimediaViewer;
-
- // Quick hack to select all text in a text box
- $.fn.selectAll = function () {
- return this.each( function () {
- var range,
- start = 0,
- end = this.value.length;
-
- if ( this.setSelectionRange ) {
- this.setSelectionRange( start, end );
- } else if ( this.createTextRange ) {
- range = this.createTextRange();
- range.collapse( true );
- range.moveEnd( 'character', end );
- range.moveStart( 'character', start );
- range.select();
- }
- } );
- };
}( mediaWiki, jQuery, moment ) );
diff --git
a/resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js
b/resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js
index da591b9..12a4cd4 100644
--- a/resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js
+++ b/resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js
@@ -233,15 +233,7 @@
LIP.openFileUsageDialog = function () {
function selectAllOnEvent() {
- var $this = $( this );
-
- if ( $this.is( 'label' ) ) {
- $this = $this.parent().find( '#' + $this.prop(
'for' ) );
- }
-
- $this.selectAll();
-
- return false;
+ this.select();
}
var fileTitle = this.$useFile.data( 'title' ),
--
To view, visit https://gerrit.wikimedia.org/r/98127
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib35415115291086300494ef1c6cb3063cd6b8e94
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: Poke <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
