Matanya has uploaded a new change for review.
https://gerrit.wikimedia.org/r/98456
Change subject: role.pp: minor lint clean
......................................................................
role.pp: minor lint clean
Change-Id: Ib22d19ce9b2827e533d3bfe418d1956c52c496c1
---
M modules/system/manifests/role.pp
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/56/98456/1
diff --git a/modules/system/manifests/role.pp b/modules/system/manifests/role.pp
index 0c59c5b..edd95ca 100644
--- a/modules/system/manifests/role.pp
+++ b/modules/system/manifests/role.pp
@@ -1,20 +1,20 @@
# Prints a MOTD message about the role of this system
define system::role($description, $ensure=present) {
- $role_script_content = "#!/bin/sh
+ $role_script_content = "#!/bin/sh
echo \"$(hostname) is a Wikimedia ${description} (${title}).\"
"
- $rolename = regsubst($title, ":", "-", "G")
- $motd_filename = "/etc/update-motd.d/05-role-${rolename}"
+ $rolename = regsubst($title, ':', '-', 'G')
+ $motd_filename = "/etc/update-motd.d/05-role-${rolename}"
- if $::lsbdistid == "Ubuntu" and versioncmp($::lsbdistrelease, "9.10")
>= 0 {
- file { $motd_filename:
- owner => root,
- group => root,
- mode => 0555,
- content => $role_script_content,
- ensure => $ensure;
- }
- }
+ if $::lsbdistid == 'Ubuntu' and versioncmp($::lsbdistrelease, '9.10') >= 0
{
+ file { $motd_filename:
+ ensure => $ensure,
+ owner => 'root',
+ group => 'root',
+ mode => '0555',
+ content => $role_script_content,
+ }
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/98456
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib22d19ce9b2827e533d3bfe418d1956c52c496c1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Matanya <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
