jenkins-bot has submitted this change and it was merged.
Change subject: Suppress on sender's deeper user subpages
......................................................................
Suppress on sender's deeper user subpages
WikiLove fails to suppress on sender's own user subpages
deeper than one level (= with more than one "/" in the page
name). This patch prevents the WikiLove tab from being
shown on own user subpages by finding root title instead of
base title.
Change-Id: I6204709119c1272b8fae524a28690c59e796943e
---
M WikiLove.hooks.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Legoktm: Looks good to me, but someone else must approve
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WikiLove.hooks.php b/WikiLove.hooks.php
index cecac84..e4ecdd4 100644
--- a/WikiLove.hooks.php
+++ b/WikiLove.hooks.php
@@ -172,8 +172,8 @@
return wfMessage( 'wikilove-err-invalid-username'
)->plain();
}
- // If we're on a subpage, get the base page title
- $baseTitle = $title->getBaseTitle();
+ // If we're on a subpage, get the root page title
+ $baseTitle = $title->getRootTitle();
// Users can't send WikiLove to themselves
if ( $wgUser->getName() === $baseTitle->getText() ) {
--
To view, visit https://gerrit.wikimedia.org/r/98362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6204709119c1272b8fae524a28690c59e796943e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikiLove
Gerrit-Branch: master
Gerrit-Owner: Whym <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
