Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/98608
Change subject: Followup eb95d7b0b2: don't hide the inspectors WindowSet at all
......................................................................
Followup eb95d7b0b2: don't hide the inspectors WindowSet at all
There's no point in hiding the WindowSet if we've already closed the
open window in it. In fact, there's no point in hiding a WindowSet
pretty much ever.
Change-Id: I49a02b5d255b266eb9e0a537cb64082eb0ad5e4b
---
M modules/ve/ui/ve.ui.Context.js
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/08/98608/1
diff --git a/modules/ve/ui/ve.ui.Context.js b/modules/ve/ui/ve.ui.Context.js
index 0ff9884..01b8226 100644
--- a/modules/ve/ui/ve.ui.Context.js
+++ b/modules/ve/ui/ve.ui.Context.js
@@ -402,9 +402,6 @@
// Show either inspector or menu
if ( inspector ) {
this.$menu.hide();
- // Use visibility instead of .show()/.hide() so Firefox
won't refuse to load the iframe
- // inside the inspector (bug 57568)
- this.inspectors.$element.css( 'visibility', '' );
if ( !repositionOnly ) {
inspector.$element.css( 'opacity', 0 );
}
@@ -415,9 +412,6 @@
inspector.$element.css( 'opacity', 1 );
}, this ), 200 );
} else {
- // Use visibility instead of .show()/.hide() so Firefox
won't refuse to load the iframe
- // inside the inspector (bug 57568)
- this.inspectors.$element.css( 'visibility', 'hidden' );
this.embedded = (
focusedNode &&
focusedNode.$focusable.outerHeight() >
this.$menu.outerHeight() * 2 &&
--
To view, visit https://gerrit.wikimedia.org/r/98608
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49a02b5d255b266eb9e0a537cb64082eb0ad5e4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
