MarkTraceur has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/98690


Change subject: Fix a bloody silly file usage dialog bug
......................................................................

Fix a bloody silly file usage dialog bug

Return false from the click handler so it doesn't fire a popstate event
because the link is to "#"

Change-Id: I08a49e1b664dc4e6b01c1f479209428578d36843
---
M resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/90/98690/1

diff --git 
a/resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js 
b/resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js
index ad9216f..4e9db2f 100644
--- a/resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js
+++ b/resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js
@@ -227,6 +227,7 @@
                        .text( mw.message( 'multimediaviewer-use-file' ).text() 
)
                        .click( function () {
                                ui.openFileUsageDialog();
+                               return false;
                        } )
                        .appendTo( this.$useFileLi );
        };

-- 
To view, visit https://gerrit.wikimedia.org/r/98690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08a49e1b664dc4e6b01c1f479209428578d36843
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to