Ottomata has submitted this change and it was merged.
Change subject: Correctly calculate escape buffer size
......................................................................
Correctly calculate escape buffer size
Change-Id: I1d4ceb67bce73e90f88d3dee8ec8e4cb1c014bc2
---
M varnishkafka.c
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Ottomata: Verified; Looks good to me, approved
diff --git a/varnishkafka.c b/varnishkafka.c
index 373931d..0be3ecc 100644
--- a/varnishkafka.c
+++ b/varnishkafka.c
@@ -432,10 +432,10 @@
char *d;
const char *s, *srcend = src + len;
- /* Allocate initial space for escaped string. */
+ /* Allocate initial space for escaped string.
+ * The maximum expansion size per character is 5 (octal coding). */
dst = scratch_alloc(tag, lp, len * 5);
-
- dstend = dst + len + 10;
+ dstend = dst + (len * 5);
s = src;
d = dst;
--
To view, visit https://gerrit.wikimedia.org/r/98134
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d4ceb67bce73e90f88d3dee8ec8e4cb1c014bc2
Gerrit-PatchSet: 2
Gerrit-Project: operations/software/varnish/varnishkafka
Gerrit-Branch: master
Gerrit-Owner: Edenhill <[email protected]>
Gerrit-Reviewer: Edenhill <[email protected]>
Gerrit-Reviewer: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
