jenkins-bot has submitted this change and it was merged.
Change subject: Use visibility: hidden; for the ui.Context and its popup
......................................................................
Use visibility: hidden; for the ui.Context and its popup
They contain iframes and those need to not be display: none;
in order to make Firefox happy.
Bug: 57568
Change-Id: I177877bff3c3b18bfc87ee4e6afa7e60fea26ffc
---
M modules/ve/ui/ve.ui.Context.js
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ui/ve.ui.Context.js b/modules/ve/ui/ve.ui.Context.js
index 01b8226..8230c6c 100644
--- a/modules/ve/ui/ve.ui.Context.js
+++ b/modules/ve/ui/ve.ui.Context.js
@@ -396,7 +396,11 @@
if ( !this.showing && !this.hiding ) {
this.showing = true;
- this.$element.show();
+ // HACK: make the context and popup visibility: hidden; instead
of display: none; because
+ // they contain inspector iframes, and applying display: none;
to those causes them to
+ // not load in Firefox
+ this.$element.css( 'visibility', '' );
+ this.popup.$element.css( 'visibility', '' );
this.popup.show();
// Show either inspector or menu
@@ -444,8 +448,12 @@
if ( inspector ) {
inspector.close( { 'action': 'hide' } );
}
+ // HACK: make the context and popup visibility: hidden; instead
of display: none; because
+ // they contain inspector iframes, and applying display: none;
to those causes them to
+ // not load in Firefox
this.popup.hide();
- this.$element.hide();
+ this.popup.$element.show().css( 'visibility', 'hidden' );
+ this.$element.css( 'visibility', 'hidden' );
this.visible = false;
this.hiding = false;
}
--
To view, visit https://gerrit.wikimedia.org/r/98688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I177877bff3c3b18bfc87ee4e6afa7e60fea26ffc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
