jenkins-bot has submitted this change and it was merged.
Change subject: Use Html::hidden instead of Html::input
......................................................................
Use Html::hidden instead of Html::input
Generate hidden fields with Html::hidden instead of Html::input
Change-Id: I51111f7e4f2ac284f82d3fe6547731ce99340c5c
---
M TemplateSandbox.hooks.php
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Anomie: Looks good to me, but someone else must approve
Chad: Looks good to me, approved
Nikerabbit: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/TemplateSandbox.hooks.php b/TemplateSandbox.hooks.php
index 9f1e4a4..a5f7b64 100644
--- a/TemplateSandbox.hooks.php
+++ b/TemplateSandbox.hooks.php
@@ -252,12 +252,12 @@
$html = Xml::openElement( 'span', array( 'id' =>
'templatesandbox-editform' ) );
- $html .= Html::input( 'wpTemplateSandboxTemplate',
- $editpage->templatesandbox_template, 'hidden',
array( 'id' => 'wpTemplateSandboxTemplate' )
+ $html .= Html::hidden( 'wpTemplateSandboxTemplate',
+ $editpage->templatesandbox_template, array(
'id' => 'wpTemplateSandboxTemplate' )
);
- $html .= Html::input( 'wpTemplateSandboxPage',
- $editpage->templatesandbox_page, 'hidden',
array( 'id' => 'wpTemplateSandboxPage' )
+ $html .= Html::hidden( 'wpTemplateSandboxPage',
+ $editpage->templatesandbox_page, array( 'id' =>
'wpTemplateSandboxPage' )
);
$html .= Xml::closeElement( 'span' );
@@ -285,8 +285,8 @@
$html .= Xml::tags( 'div', $textAttrs, $text->parse() )
. "\n";
}
- $html .= Html::input( 'wpTemplateSandboxTemplate',
- $editpage->templatesandbox_template, 'hidden', array(
'id' => 'wpTemplateSandboxTemplate' )
+ $html .= Html::hidden( 'wpTemplateSandboxTemplate',
+ $editpage->templatesandbox_template, array( 'id' =>
'wpTemplateSandboxTemplate' )
);
$labelText = wfMessage( 'templatesandbox-editform-page-label' );
--
To view, visit https://gerrit.wikimedia.org/r/97929
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51111f7e4f2ac284f82d3fe6547731ce99340c5c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateSandbox
Gerrit-Branch: master
Gerrit-Owner: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
