jenkins-bot has submitted this change and it was merged.
Change subject: Change CdbException to subclass Exception
......................................................................
Change CdbException to subclass Exception
Nothing really makes use of this yet outside of core, so should be
ok and minimal impact.
Change-Id: Iab9f7fe0df41d8020d6ccd4e860af6d045948aee
---
M includes/utils/Cdb.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/utils/Cdb.php b/includes/utils/Cdb.php
index 0995aed..f556ee7 100644
--- a/includes/utils/Cdb.php
+++ b/includes/utils/Cdb.php
@@ -155,6 +155,7 @@
}
/**
- * Exception for Cdb errors
+ * Exception for Cdb errors.
+ * This explicitly doesn't subclass MWException to encourage reuse.
*/
-class CdbException extends MWException {}
+class CdbException extends Exception {}
--
To view, visit https://gerrit.wikimedia.org/r/96910
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab9f7fe0df41d8020d6ccd4e860af6d045948aee
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits