01tonythomas has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/99163


Change subject: Removed "Disable search suggestions" from Mediawiki Preference
......................................................................

Removed "Disable search suggestions" from Mediawiki Preference

It's rarely used and provide more interface clutter and code complexity than
any benefit it might provide.

Bug: 52812
Change-Id: I4b1d243b1b1a9da484147c4a682f44aa08a22803
---
M RELEASE-NOTES-1.23
M includes/Preferences.php
M languages/messages/MessagesEn.php
M maintenance/language/messages.inc
4 files changed, 1 insertion(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/63/99163/1

diff --git a/RELEASE-NOTES-1.23 b/RELEASE-NOTES-1.23
index 4697b4d..019833b 100644
--- a/RELEASE-NOTES-1.23
+++ b/RELEASE-NOTES-1.23
@@ -93,6 +93,7 @@
   mw.toolbar.insertTags) now emits mw.log.warn when accessed.
 * User::getPageRenderingHash() was deprecated since 1.17 and has been removed.
 * The ExpandTemplates extension has been moved into MediaWiki core.
+* (bug 52812) Removed "Disable search suggestions" from Preference.
 
 == Compatibility ==
 
diff --git a/includes/Preferences.php b/includes/Preferences.php
index d498770..cf4d5c9 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -1062,12 +1062,6 @@
                        );
                }
 
-               $defaultPreferences['disablesuggest'] = array(
-                       'type' => 'toggle',
-                       'label-message' => 'mwsuggest-disable',
-                       'section' => 'searchoptions/displaysearchoptions',
-               );
-
                $defaultPreferences['searcheverything'] = array(
                        'type' => 'toggle',
                        'label-message' => 'searcheverything-enable',
diff --git a/languages/messages/MessagesEn.php 
b/languages/messages/MessagesEn.php
index 1bd59b2..043407f 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -1850,7 +1850,6 @@
 'search-interwiki-custom'          => '', # do not translate or duplicate this 
message to other languages
 'search-interwiki-more'            => '(more)',
 'search-relatedarticle'            => 'Related',
-'mwsuggest-disable'                => 'Disable search suggestions',
 'searcheverything-enable'          => 'Search in all namespaces',
 'searchrelated'                    => 'related',
 'searchall'                        => 'all',
diff --git a/maintenance/language/messages.inc 
b/maintenance/language/messages.inc
index 947dfe9..036f6e6 100644
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -993,7 +993,6 @@
                'search-interwiki-custom',
                'search-interwiki-more',
                'search-relatedarticle',
-               'mwsuggest-disable',
                'searcheverything-enable',
                'searchrelated',
                'searchall',

-- 
To view, visit https://gerrit.wikimedia.org/r/99163
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b1d243b1b1a9da484147c4a682f44aa08a22803
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: 01tonythomas <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to