Faidon Liambotis has uploaded a new change for review.
https://gerrit.wikimedia.org/r/99342
Change subject: varnish: sort bits esams backends
......................................................................
varnish: sort bits esams backends
It currently oscillates between pmtpa/eqiad & eqiad/pmtpa, forcing a VCL
reload on half of the puppet runs.
Fix this by sorting the list on cache.pp, rather than sorting the
backends list in the erb template; it would be equivalent right now, but
we might use the "fallback" director at some point and backend order
matters with that director, so let's have our erbs be future-proof.
Change-Id: I1b542fa77b323a11e4ba1a34a4753d270361bef9
---
M manifests/role/cache.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/42/99342/1
diff --git a/manifests/role/cache.pp b/manifests/role/cache.pp
index 5d6990d..d46d93e 100644
--- a/manifests/role/cache.pp
+++ b/manifests/role/cache.pp
@@ -885,7 +885,7 @@
"test_wikipedia" =>
$::role::cache::configuration::backends[$::realm]['test_appservers'][$::mw_primary],
},
2 => {
- "backend" =>
flatten(values($role::cache::configuration::backends[$::realm]['bits']))
+ "backend" =>
sort(flatten(values($role::cache::configuration::backends[$::realm]['bits'])))
}
}
--
To view, visit https://gerrit.wikimedia.org/r/99342
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b542fa77b323a11e4ba1a34a4753d270361bef9
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
