Tpt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/99386
Change subject: Fix fatal error in ProofreadPageLevel
......................................................................
Fix fatal error in ProofreadPageLevel
Change-Id: I6485a4745be75f3f41139477be3d1e0133171fde
---
M includes/page/ProofreadPageLevel.php
M tests/includes/page/ProofreadPageLevelTest.php
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/86/99386/1
diff --git a/includes/page/ProofreadPageLevel.php
b/includes/page/ProofreadPageLevel.php
index 4346676..c93fce9 100644
--- a/includes/page/ProofreadPageLevel.php
+++ b/includes/page/ProofreadPageLevel.php
@@ -98,7 +98,8 @@
return false;
}
- if ( $to->getLevel() === 4 && ( $this->level < 3 ||
$this->level === 3 && $this->user->getName() === $to->getUser()->getName() ) ) {
+ $fromUser = ( $this->user instanceof User ) ? $this->user :
$to->getUser();
+ if ( $to->getLevel() === 4 && ( $this->level < 3 ||
$this->level === 3 && $fromUser->getName() === $to->getUser()->getName() ) ) {
return false;
}
diff --git a/tests/includes/page/ProofreadPageLevelTest.php
b/tests/includes/page/ProofreadPageLevelTest.php
index 89ad2aa..d68d52d 100644
--- a/tests/includes/page/ProofreadPageLevelTest.php
+++ b/tests/includes/page/ProofreadPageLevelTest.php
@@ -72,6 +72,11 @@
new ProofreadPageLevel( 4, $test2User ),
false
),
+ array(
+ new ProofreadPageLevel( 1, null ),
+ new ProofreadPageLevel( 4, $testUser ),
+ false
+ ),
);
}
--
To view, visit https://gerrit.wikimedia.org/r/99386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6485a4745be75f3f41139477be3d1e0133171fde
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt <thoma...@hotmail.fr>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
