Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/99398
Change subject: Declare visibility on class properties of Exif
......................................................................
Declare visibility on class properties of Exif
Change-Id: Ia729bd114e1d48864aa0a37f5a5ba13e6fa5a313
---
M includes/media/Exif.php
1 file changed, 21 insertions(+), 48 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/98/99398/1
diff --git a/includes/media/Exif.php b/includes/media/Exif.php
index bc55000..7593a16 100644
--- a/includes/media/Exif.php
+++ b/includes/media/Exif.php
@@ -66,64 +66,37 @@
/** A fake value for things we don't want or don't support. */
const IGNORE = -1;
- //@{
- /* @var array
- * @private
+ /** @var array Exif tags grouped by category, the tagname itself is the
key
+ * and the type is the value, in the case of more than one possible
value
+ * type they are separated by commas.
*/
+ private $mExifTags;
- /**
- * Exif tags grouped by category, the tagname itself is the key and the
type
- * is the value, in the case of more than one possible value type they
are
- * separated by commas.
+ /** @var array The raw Exif data returned by exif_read_data() */
+ private $mRawExifData;
+
+ /** @var array A Filtered version of $mRawExifData that has been pruned
+ * of invalid tags and tags that contain content they shouldn't
contain
+ * according to the Exif specification
*/
- var $mExifTags;
+ private $mFilteredExifData;
- /**
- * The raw Exif data returned by exif_read_data()
- */
- var $mRawExifData;
+ /** @var array Filtered and formatted Exif data, see
FormatMetadata::getFormattedData() */
+ private $mFormattedExifData;
- /**
- * A Filtered version of $mRawExifData that has been pruned of invalid
- * tags and tags that contain content they shouldn't contain according
- * to the Exif specification
- */
- var $mFilteredExifData;
+ /** @var string The file being processed */
+ private $file;
- /**
- * Filtered and formatted Exif data, see
FormatMetadata::getFormattedData()
- */
- var $mFormattedExifData;
+ /** @var string The basename of the file being processed */
+ private $basename;
- //@}
+ /** @var string The private log to log to, e.g. 'exif' */
+ private $log = false;
- //@{
- /* @var string
- * @private
- */
-
- /**
- * The file being processed
- */
- var $file;
-
- /**
- * The basename of the file being processed
- */
- var $basename;
-
- /**
- * The private log to log to, e.g. 'exif'
- */
- var $log = false;
-
- /**
- * The byte order of the file. Needed because php's
- * extension doesn't fully process some obscure props.
+ /** @var string The byte order of the file. Needed because php's
extension
+ * doesn't fully process some obscure props.
*/
private $byteOrder;
-
- //@}
/**
* Constructor
--
To view, visit https://gerrit.wikimedia.org/r/99398
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia729bd114e1d48864aa0a37f5a5ba13e6fa5a313
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
