[MediaWiki-commits] [Gerrit] Use higher ids in SetReferenceTest to fix travis - change (mediawiki...Wikibase)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/99399


Change subject: Use higher ids in SetReferenceTest to fix travis
......................................................................

Use higher ids in SetReferenceTest to fix travis

Change-Id: I63557f8c75e96c4497bdcfcd89328298942e6cd9
---
M repo/tests/phpunit/includes/api/SetReferenceTest.php
1 file changed, 16 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/99/99399/1

diff --git a/repo/tests/phpunit/includes/api/SetReferenceTest.php 
b/repo/tests/phpunit/includes/api/SetReferenceTest.php
index 928d99e..941909d 100644
--- a/repo/tests/phpunit/includes/api/SetReferenceTest.php
+++ b/repo/tests/phpunit/includes/api/SetReferenceTest.php
@@ -5,7 +5,6 @@
 use DataValues\StringValue;
 use FormatJson;
 use UsageException;
-use Wikibase\DataModel\Entity\PropertyId;
 use Wikibase\Item;
 use Wikibase\ItemContent;
 use Wikibase\Lib\Serializers\SerializerFactory;
@@ -42,12 +41,10 @@
        public function setUp() {
                static $hasProperties = false;
                if ( !$hasProperties ) {
-                       $this->createProperty( 1 );
-                       $this->createProperty( 2 );
-                       $this->createProperty( 3 );
-                       $this->createProperty( 42 );
-                       $this->createProperty( 43 );
-                       $this->createProperty( 66 );
+                       $this->createProperty( 100 );
+                       $this->createProperty( 4200 );
+                       $this->createProperty( 4300 );
+                       $this->createProperty( 6600 );
 
                        $hasProperties = true;
                }
@@ -74,11 +71,11 @@
                $content = new ItemContent( $item );
                $content->save( '', null, EDIT_NEW );
 
-               $statement = $item->newClaim( new PropertyNoValueSnak( 42 ) );
+               $statement = $item->newClaim( new PropertyNoValueSnak( 4200 ) );
                $statement->setGuid( $item->getId()->getPrefixedId() . 
'$D8505CDA-25E4-4334-AG93-A3290BCD9C0P' );
 
                $reference = new Reference( new SnakList(
-                       array( new PropertySomeValueSnak( 1 ) )
+                       array( new PropertySomeValueSnak( 100 ) )
                ) );
 
                $statement->getReferences()->addReference( $reference );
@@ -90,7 +87,7 @@
                $referenceHash = $reference->getHash();
 
                $reference = new Reference( new SnakList(
-                       array( new PropertyNoValueSnak( 42 ) )
+                       array( new PropertyNoValueSnak( 4200 ) )
                ) );
 
                $serializedReference = $this->makeValidRequest(
@@ -110,8 +107,8 @@
 
                $reference = new Reference( new SnakList(
                        array(
-                               new PropertyNoValueSnak( 42 ),
-                               new PropertyNoValueSnak( 43 ),
+                               new PropertyNoValueSnak( 4200 ),
+                               new PropertyNoValueSnak( 4300 ),
                        )
                ) );
 
@@ -142,7 +139,7 @@
                $content->save( '', null, EDIT_NEW );
 
                // Create a statement to act upon:
-               $statement = $item->newClaim( new PropertyNoValueSnak( 42 ) );
+               $statement = $item->newClaim( new PropertyNoValueSnak( 4200 ) );
                $statement->setGuid(
                        $item->getId()->getPrefixedId() . 
'$D8505CDA-25E4-4334-AG93-A3290BCD9C0P'
                );
@@ -162,16 +159,16 @@
                $content->save( '', null, EDIT_NEW );
 
                // Create a statement to act upon:
-               $statement = $item->newClaim( new PropertyNoValueSnak( 42 ) );
+               $statement = $item->newClaim( new PropertyNoValueSnak( 4200 ) );
                $statement->setGuid(
                        $item->getId()->getPrefixedId() . 
'$D8505CDA-25E4-4334-AG93-A3290BCD9C0P'
                );
 
                // Pre-fill statement with three references:
                $references = array(
-                       new Reference( new SnakList( array( new 
PropertySomeValueSnak( 42 ) ) ) ),
-                       new Reference( new SnakList( array( new 
PropertySomeValueSnak( 43 ) ) ) ),
-                       new Reference( new SnakList( array( new 
PropertySomeValueSnak( 66 ) ) ) ),
+                       new Reference( new SnakList( array( new 
PropertySomeValueSnak( 4200 ) ) ) ),
+                       new Reference( new SnakList( array( new 
PropertySomeValueSnak( 4300 ) ) ) ),
+                       new Reference( new SnakList( array( new 
PropertySomeValueSnak( 6600 ) ) ) ),
                );
 
                foreach( $references as $reference ) {
@@ -331,10 +328,10 @@
        }
 
        public function invalidClaimProvider() {
-               $snak = new PropertyValueSnak( 42, new StringValue( 'abc') );
+               $snak = new PropertyValueSnak( 4200, new StringValue( 'abc') );
                $snakHash = $snak->getHash();
 
-               $reference = new PropertyValueSnak( 42, new StringValue( 'def' 
) );
+               $reference = new PropertyValueSnak( 4200, new StringValue( 
'def' ) );
                $refHash = $reference->getHash();
 
                return array(

-- 
To view, visit https://gerrit.wikimedia.org/r/99399
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63557f8c75e96c4497bdcfcd89328298942e6cd9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits