Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/99551
Change subject: Regression: Fix file uploads
......................................................................
Regression: Fix file uploads
The change introduced in Iadb4ee2b336e07ae2dfec7f09798ba210f409f6b
prevents uploads from having format=json set. This rectifies that.
Change-Id: I5ac0f7aa26f28841ad1a2c1a9cca07d0e5f8a2c0
---
M javascripts/common/api.js
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/51/99551/1
diff --git a/javascripts/common/api.js b/javascripts/common/api.js
index 739d262..afe4cb0 100644
--- a/javascripts/common/api.js
+++ b/javascripts/common/api.js
@@ -39,13 +39,12 @@
* @return {jQuery.Deferred} Object returned by $.ajax()
*/
ajax: function( data, options ) {
- var key, request, self = this;
+ var key, request, self = this, isFormData, isDataObject;
options = $.extend( { url: apiUrl, dataType: 'json' },
options );
+ isFormData = typeof FormData !== 'undefined' && data
instanceof FormData;
+ isDataObject = typeof data !== 'string' && !isFormData;
- if (
- typeof data !== 'string' &&
- ( typeof FormData === 'undefined' || !(
data instanceof FormData ) )
- ) {
+ if ( isDataObject ) {
for ( key in data ) {
if ( data[key] === false ) {
delete data[key];
@@ -53,8 +52,11 @@
data[key] = data[key].join( '|'
);
}
}
+ options.data = $.extend( { format: 'json' },
data );
+ } else if ( isFormData ) {
+ data.append( 'format', 'json' );
+ options.data = data;
}
- options.data = $.extend( { format: 'json' }, data );
options.xhr = function() {
var xhr = $.ajaxSettings.xhr();
--
To view, visit https://gerrit.wikimedia.org/r/99551
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ac0f7aa26f28841ad1a2c1a9cca07d0e5f8a2c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
