EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/99559


Change subject: Group revision by the type(header or post id) in 
RevisionStorage::findMostRecent
......................................................................

Group revision by the type(header or post id) in RevisionStorage::findMostRecent

Change-Id: Idb29d37a81ebf76fa7762e3e2cd2d87c25bb3baf
---
M includes/Data/RevisionStorage.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/59/99559/1

diff --git a/includes/Data/RevisionStorage.php 
b/includes/Data/RevisionStorage.php
index f85db8f..008d923 100644
--- a/includes/Data/RevisionStorage.php
+++ b/includes/Data/RevisionStorage.php
@@ -134,7 +134,7 @@
                        array( $joinField => "MAX( {$this->joinField()} )" ),
                        $this->preprocessSqlArray( 
$this->buildCompositeInCondition( $dbr, $duplicator->getUniqueQueries() ) ),
                        __METHOD__,
-                       array( 'GROUP BY' => $keys )
+                       array( 'GROUP BY' => $this->relatedPk() )
                );
                if ( !$res ) {
                        // TODO: dont fail, but dont end up caching bad result 
either

-- 
To view, visit https://gerrit.wikimedia.org/r/99559
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb29d37a81ebf76fa7762e3e2cd2d87c25bb3baf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to