Mollywhite has submitted this change and it was merged.
Change subject: WebRequest::getCheck is never null
......................................................................
WebRequest::getCheck is never null
It returns a boolean, which is never null.
Change-Id: Ife1579b6778bdf6a1b045b464602339c5009d7e6
---
M BookManagerv2.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mollywhite: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/BookManagerv2.hooks.php b/BookManagerv2.hooks.php
index 59bb7fa..80ff2a6 100644
--- a/BookManagerv2.hooks.php
+++ b/BookManagerv2.hooks.php
@@ -422,7 +422,7 @@
$request = $out->getRequest();
- if ( !$wgBookManagerv2NavigationBars || !is_null(
$request->getCheck( 'wpDiff' ) ) ) {
+ if ( !$wgBookManagerv2NavigationBars || $request->getCheck(
'wpDiff' ) ) {
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/99593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife1579b6778bdf6a1b045b464602339c5009d7e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BookManagerv2
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Mollywhite <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
