Mollywhite has submitted this change and it was merged.
Change subject: Notice: Undefined variable: jsonPageTitle in
BookManagerv2.hooks.php on line 527
......................................................................
Notice: Undefined variable: jsonPageTitle in BookManagerv2.hooks.php on line 527
Change-Id: I537d1a913ab4e4a4a5c796222d85174eac70b400
---
M BookManagerv2.hooks.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Mollywhite: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/BookManagerv2.hooks.php b/BookManagerv2.hooks.php
index 526d99a..9593228 100644
--- a/BookManagerv2.hooks.php
+++ b/BookManagerv2.hooks.php
@@ -333,6 +333,7 @@
* will be linked.
*
* @param object $sections Sections property of the JSON
+ * @param Title $jsonPageTitle
* @param string $currentPageTitle Title of the page that's being viewed
* @return string HTML ordered list element
*/
@@ -372,6 +373,7 @@
*
* @param IContextSource $context
* @param object $jsonBook JSON representation of the book
+ * @param Title $jsonPageTitle
* @return string HTML unordered list element
*/
public static function formatMetadata( $context, $jsonBook,
$jsonPageTitle = null ) {
@@ -446,7 +448,7 @@
$out->addModuleStyles( "ext.BookManagerv2" );
$out->addModules( "ext.BookManagerv2js" );
$currentPageTitle = $out->getTitle()->getText();
- $prev = $next = $jsonBook = null;
+ $prev = $next = $jsonBook = $jsonPageTitle =
null;
foreach ( $categories as $cat ) {
if ( substr( $cat, 0, strlen(
$namespace ) ) === $namespace ) {
$jsonPageTitle =
Title::newFromText( $cat );
--
To view, visit https://gerrit.wikimedia.org/r/99615
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I537d1a913ab4e4a4a5c796222d85174eac70b400
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BookManagerv2
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Mollywhite <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
