jenkins-bot has submitted this change and it was merged.
Change subject: Make delete test less flaky
......................................................................
Make delete test less flaky
Instead of arbitrary wait times it now:
* Verifies that the index operation worked in the first place
* Waits *up to* 75 seconds for the delete but typically catches it after
one or two. 75 is used because that is a nice long timeout for beta in
case its job queue is backed up.
Change-Id: I694d845b25ec06de6a29d71f468b319f235c5344
---
M tests/browser/features/updates.feature
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/updates.feature
b/tests/browser/features/updates.feature
index dc4ea1a..cd56b66 100644
--- a/tests/browser/features/updates.feature
+++ b/tests/browser/features/updates.feature
@@ -1,14 +1,12 @@
Feature: Search backend updates
Background:
Given I am logged in
+
Scenario: Deleted pages are removed from the index
Given a page named DeleteMe exists
+ Then within 75 seconds searching for DeleteMe yields DeleteMe as the first
result
When I delete DeleteMe
- And I am at a random page so I can reload it if I need to
- And wait 5 seconds
- And I type DeleteMe into the search box
- Then suggestions should appear
- And none is the first suggestion
+ Then within 75 seconds searching for DeleteMe yields none as the first
result
Scenario: Altered pages are updated in the index
Given a page named ChangeMe exists with contents foo
--
To view, visit https://gerrit.wikimedia.org/r/99667
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I694d845b25ec06de6a29d71f468b319f235c5344
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Manybubbles <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
