jenkins-bot has submitted this change and it was merged.
Change subject: Prefetch wikitext on summary screen
......................................................................
Prefetch wikitext on summary screen
This reflects recent changes to the save method in the mw.target module
Exchange html to wikitext from parsoid in the summary view,
once fetched, the submit (or save) button becomes enabled.
Change-Id: I81191b3e8895b0041ab08c6b1e15589ca5656e88
---
M javascripts/modules/editor/VisualEditorOverlay.js
1 file changed, 17 insertions(+), 8 deletions(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/editor/VisualEditorOverlay.js
b/javascripts/modules/editor/VisualEditorOverlay.js
index 6501506..f78a81c 100644
--- a/javascripts/modules/editor/VisualEditorOverlay.js
+++ b/javascripts/modules/editor/VisualEditorOverlay.js
@@ -14,7 +14,6 @@
summaryMsg: mw.msg(
'mobile-frontend-editor-summary-placeholder' ),
licenseMsg: mw.msg( 'mobile-frontend-editor-license' )
},
-
initialize: function( options ) {
var self = this;
this.hasChanged = false;
@@ -33,20 +32,30 @@
this._super( options );
},
prepareForSave: function() {
- this._showHidden( '.save-header, .save-panel' );
+ var self = this,
+ doc =
this.target.surface.getModel().getDocument();
+ // Disable VE surface
+ this.target.surface.getView().disable();
+ self._showHidden( '.save-header, .save-panel' );
+ self.$( '.submit' ).prop( 'disabled', true );
+ this.$spinner.show();
+ // Preload the serialization
+ if ( !this.docToSave ) {
+ this.docToSave =
ve.dm.converter.getDomFromModel( doc );
+ }
+ this.target.prepareCacheKey( this.docToSave ).done(
function () {
+ self.clearSpinner();
+ self.$( '.submit' ).prop( 'disabled', false );
+ } );
},
save: function() {
- var doc = this.target.surface.getModel().getDocument(),
- summary = this.$( '.save-panel input' ).val();
+ var summary = this.$( '.save-panel input' ).val();
this.$spinner.show();
// Stop the confirmation message from being thrown when
you hit save.
this.canHide = true;
this.$( '.surface, .summary-area' ).hide();
- this.target.save(
- ve.dm.converter.getDomFromData(
doc.getFullData(), doc.getStore(), doc.getInternalList(),
doc.getInnerWhitespace() ),
- { 'summary': summary }
- );
+ this.target.save( this.docToSave, { 'summary': summary
} );
},
clearSpinner: function() {
this.$spinner.hide();
--
To view, visit https://gerrit.wikimedia.org/r/99591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81191b3e8895b0041ab08c6b1e15589ca5656e88
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
