Dzahn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/99727


Change subject: fix parameter order in bugzilla logmail
......................................................................

fix parameter order in bugzilla logmail

lint WARN 'optional parameter listed before required parameter'

e.g. http://puppet-lint.com/checks/parameter_order/

this removes the last lint issue in the new module

Change-Id: I61c21827db4dac6d924796f1acce2ce0398d3eff
---
M modules/bugzilla/manifests/logmail.pp
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/27/99727/1

diff --git a/modules/bugzilla/manifests/logmail.pp 
b/modules/bugzilla/manifests/logmail.pp
index 6d376d6..d74d347 100644
--- a/modules/bugzilla/manifests/logmail.pp
+++ b/modules/bugzilla/manifests/logmail.pp
@@ -2,11 +2,11 @@
 # like admin audit log and community metrics
 
 define bugzilla::logmail (
-    $bz_path     = '/srv/org/wikimedia/bugzilla',
     $script_name,
-    $script_user = 'www-data',
-    $rcpt_address,
     $sndr_address,
+    $rcpt_address,
+    $bz_path     = '/srv/org/wikimedia/bugzilla',
+    $script_user = 'www-data',
     $hour        = '0',
     $minute      = '0',
     $monthday    = '*',

-- 
To view, visit https://gerrit.wikimedia.org/r/99727
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61c21827db4dac6d924796f1acce2ce0398d3eff
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to