Yuvipanda has submitted this change and it was merged. Change subject: Fix SVG->PNG icon rasterization for higher resolutions ......................................................................
Fix SVG->PNG icon rasterization for higher resolutions * using librsvg instead of convert * added note to main README about how to run it * added xxhdpi output (yes it's slightly more sharper and beautiful, especially for line-art icons like this!) Change-Id: I8b8c49a53434b2eadccb9533feadcd3d4dff1d9c --- M README.md M wikipedia/convertify.bash M wikipedia/res/drawable-hdpi/external.png M wikipedia/res/drawable-hdpi/link.png M wikipedia/res/drawable-hdpi/random.png M wikipedia/res/drawable-hdpi/search.png M wikipedia/res/drawable-mdpi/external.png M wikipedia/res/drawable-mdpi/link.png M wikipedia/res/drawable-mdpi/random.png M wikipedia/res/drawable-mdpi/search.png M wikipedia/res/drawable-xhdpi/external.png M wikipedia/res/drawable-xhdpi/link.png M wikipedia/res/drawable-xhdpi/random.png M wikipedia/res/drawable-xhdpi/search.png A wikipedia/res/drawable-xxhdpi/external.png A wikipedia/res/drawable-xxhdpi/link.png A wikipedia/res/drawable-xxhdpi/random.png A wikipedia/res/drawable-xxhdpi/search.png 18 files changed, 22 insertions(+), 3 deletions(-) Approvals: Yuvipanda: Verified; Looks good to me, approved diff --git a/README.md b/README.md index 4ca21cc..0c1a524 100644 --- a/README.md +++ b/README.md @@ -1,2 +1,20 @@ See also https://git.wikimedia.org/summary/apps%2Fandroid%2Fjava-mwapi.git + +== Updating icons from SVG == + +Many of our icons are maintained as SVG originals, rasterized to PNG at the +various output resolutions via a script. This rasterization is not part of +the main build process, so needs to be re-run when adding new icons. + +Ensure you have librsvg and the 'rsvg-convert' command: + +* On Ubuntu, run "sudo apt-get install librsvg2-bin" +* On Mac OS X using Homebrew, run "brew install librsvg" + +In "wikipedia" project subdirectory, run: +* "./convertify.bash" + +Original files from icon-sources/*.svg are rendered and copied into the res/ +subdirectories. Note that they are not automatically added to git! + diff --git a/wikipedia/convertify.bash b/wikipedia/convertify.bash index 3a0768e..10bc087 100755 --- a/wikipedia/convertify.bash +++ b/wikipedia/convertify.bash @@ -4,7 +4,8 @@ do echo "Converting $F" IMGNAME=`basename $F .svg` - convert -resize 32x32 -background none "$F" "res/drawable-mdpi/$IMGNAME.png" - convert -resize 48x48 -background none "$F" "res/drawable-hdpi/$IMGNAME.png" - convert -resize 72x72 -background none "$F" "res/drawable-xhdpi/$IMGNAME.png" + rsvg-convert -w 32 -h 32 -o "res/drawable-mdpi/$IMGNAME.png" "$F" + rsvg-convert -w 48 -h 48 -o "res/drawable-hdpi/$IMGNAME.png" "$F" + rsvg-convert -w 72 -h 72 -o "res/drawable-xhdpi/$IMGNAME.png" "$F" + rsvg-convert -w 96 -h 96 -o "res/drawable-xxhdpi/$IMGNAME.png" "$F" done diff --git a/wikipedia/res/drawable-hdpi/external.png b/wikipedia/res/drawable-hdpi/external.png index 4548d46..ade9a31 100644 --- a/wikipedia/res/drawable-hdpi/external.png +++ b/wikipedia/res/drawable-hdpi/external.png Binary files differ diff --git a/wikipedia/res/drawable-hdpi/link.png b/wikipedia/res/drawable-hdpi/link.png index 36edbaf..0759611 100644 --- a/wikipedia/res/drawable-hdpi/link.png +++ b/wikipedia/res/drawable-hdpi/link.png Binary files differ diff --git a/wikipedia/res/drawable-hdpi/random.png b/wikipedia/res/drawable-hdpi/random.png index 154066b..e06bd35 100644 --- a/wikipedia/res/drawable-hdpi/random.png +++ b/wikipedia/res/drawable-hdpi/random.png Binary files differ diff --git a/wikipedia/res/drawable-hdpi/search.png b/wikipedia/res/drawable-hdpi/search.png index 91e6833..fb6a399 100644 --- a/wikipedia/res/drawable-hdpi/search.png +++ b/wikipedia/res/drawable-hdpi/search.png Binary files differ diff --git a/wikipedia/res/drawable-mdpi/external.png b/wikipedia/res/drawable-mdpi/external.png index f721fe3..2c27a18 100644 --- a/wikipedia/res/drawable-mdpi/external.png +++ b/wikipedia/res/drawable-mdpi/external.png Binary files differ diff --git a/wikipedia/res/drawable-mdpi/link.png b/wikipedia/res/drawable-mdpi/link.png index a3bd848..79fd24f 100644 --- a/wikipedia/res/drawable-mdpi/link.png +++ b/wikipedia/res/drawable-mdpi/link.png Binary files differ diff --git a/wikipedia/res/drawable-mdpi/random.png b/wikipedia/res/drawable-mdpi/random.png index f1db6c3..764428f 100644 --- a/wikipedia/res/drawable-mdpi/random.png +++ b/wikipedia/res/drawable-mdpi/random.png Binary files differ diff --git a/wikipedia/res/drawable-mdpi/search.png b/wikipedia/res/drawable-mdpi/search.png index cd1a609..ca8cbcb 100644 --- a/wikipedia/res/drawable-mdpi/search.png +++ b/wikipedia/res/drawable-mdpi/search.png Binary files differ diff --git a/wikipedia/res/drawable-xhdpi/external.png b/wikipedia/res/drawable-xhdpi/external.png index 2c98dcf..65ee18d 100644 --- a/wikipedia/res/drawable-xhdpi/external.png +++ b/wikipedia/res/drawable-xhdpi/external.png Binary files differ diff --git a/wikipedia/res/drawable-xhdpi/link.png b/wikipedia/res/drawable-xhdpi/link.png index 966e4aa..075448b 100644 --- a/wikipedia/res/drawable-xhdpi/link.png +++ b/wikipedia/res/drawable-xhdpi/link.png Binary files differ diff --git a/wikipedia/res/drawable-xhdpi/random.png b/wikipedia/res/drawable-xhdpi/random.png index 6d776c3..cd07238 100644 --- a/wikipedia/res/drawable-xhdpi/random.png +++ b/wikipedia/res/drawable-xhdpi/random.png Binary files differ diff --git a/wikipedia/res/drawable-xhdpi/search.png b/wikipedia/res/drawable-xhdpi/search.png index 67e38d7..c7e9026 100644 --- a/wikipedia/res/drawable-xhdpi/search.png +++ b/wikipedia/res/drawable-xhdpi/search.png Binary files differ diff --git a/wikipedia/res/drawable-xxhdpi/external.png b/wikipedia/res/drawable-xxhdpi/external.png new file mode 100644 index 0000000..e276e0e --- /dev/null +++ b/wikipedia/res/drawable-xxhdpi/external.png Binary files differ diff --git a/wikipedia/res/drawable-xxhdpi/link.png b/wikipedia/res/drawable-xxhdpi/link.png new file mode 100644 index 0000000..bfc4424 --- /dev/null +++ b/wikipedia/res/drawable-xxhdpi/link.png Binary files differ diff --git a/wikipedia/res/drawable-xxhdpi/random.png b/wikipedia/res/drawable-xxhdpi/random.png new file mode 100644 index 0000000..46621c6 --- /dev/null +++ b/wikipedia/res/drawable-xxhdpi/random.png Binary files differ diff --git a/wikipedia/res/drawable-xxhdpi/search.png b/wikipedia/res/drawable-xxhdpi/search.png new file mode 100644 index 0000000..433096e --- /dev/null +++ b/wikipedia/res/drawable-xxhdpi/search.png Binary files differ -- To view, visit https://gerrit.wikimedia.org/r/99725 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b8c49a53434b2eadccb9533feadcd3d4dff1d9c Gerrit-PatchSet: 2 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Brion VIBBER <[email protected]> Gerrit-Reviewer: Yuvipanda <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
