jenkins-bot has submitted this change and it was merged.
Change subject: Fix a PHP Notice in Scribunto_LuaEngine
......................................................................
Fix a PHP Notice in Scribunto_LuaEngine
Change-Id: Ie09ec0a415c8ac72ede1ae77ba2257bbe6062505
---
M engines/LuaCommon/LuaCommon.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Anomie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index 879a147..0514c99 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -122,7 +122,7 @@
$this->interpreter->registerLibrary( 'mw_interface',
$interfaceFuncs );
$moduleFileName = $this->normalizeModuleFileName(
$moduleFileName );
$package = $this->loadLibraryFromFile( $moduleFileName );
- if ( $package['setupInterface'] ) {
+ if ( !empty( $package['setupInterface'] ) ) {
$this->interpreter->callFunction(
$package['setupInterface'], $setupOptions );
}
return $package;
--
To view, visit https://gerrit.wikimedia.org/r/100336
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie09ec0a415c8ac72ede1ae77ba2257bbe6062505
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
