Njw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/100402
Change subject: Back out of RTL part of previous commit; turns out it isn't
needed
......................................................................
Back out of RTL part of previous commit; turns out it isn't needed
The CSS reverses everything correctly anyway.
Change-Id: I743e6d6a5d63b123b633514c061959fe3fc39e2b
---
M Erudite.skin.php
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite
refs/changes/02/100402/1
diff --git a/Erudite.skin.php b/Erudite.skin.php
index 0a6de4f..5068298 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -75,10 +75,6 @@
<?php
if( array_key_exists( 'navigation',
$this->data['sidebar'] ) ) {
echo "<ul id='menu'>\n";
- /* Reverse horizontally rendered menu
items if rtl */
- if( $this->data['rtl'] ) {
- array_reverse(
$this->data['sidebar']['navigation'] );
- }
foreach(
$this->data['sidebar']['navigation'] as $item ) {
printf( '<li
id="menu-item-%s">', Sanitizer::escapeId( $item['id'] ) );
printf( '<a href="%s">%s</a>',
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
--
To view, visit https://gerrit.wikimedia.org/r/100402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I743e6d6a5d63b123b633514c061959fe3fc39e2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
