Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/100597
Change subject: Add missing tests to FlatLinearData
......................................................................
Add missing tests to FlatLinearData
Change-Id: I5a5f2c55928359951c4b811b75662517cec07540
---
M modules/ve/test/dm/lineardata/ve.dm.FlatLinearData.test.js
1 file changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/97/100597/1
diff --git a/modules/ve/test/dm/lineardata/ve.dm.FlatLinearData.test.js
b/modules/ve/test/dm/lineardata/ve.dm.FlatLinearData.test.js
index 958ba87..06fd2cd 100644
--- a/modules/ve/test/dm/lineardata/ve.dm.FlatLinearData.test.js
+++ b/modules/ve/test/dm/lineardata/ve.dm.FlatLinearData.test.js
@@ -9,6 +9,25 @@
/* Tests */
+QUnit.test( 'getType/isOpenElementData/isCloseElementData', function ( assert
) {
+ var i,
+ data = new ve.dm.FlatLinearData( new ve.dm.IndexValueStore(), [
+ { 'type': 'paragraph' },
+ 'a', ['b',[0]],
+ { 'type': '/paragraph' },
+ ] ),
+ types = ['paragraph', undefined, undefined, 'paragraph'],
+ isOpen = [0],
+ isClose = [3];
+
+ QUnit.expect( data.getLength() * 3 );
+ for ( i = 0; i < data.getLength(); i++ ) {
+ assert.equal( data.getType( i ), types[i], 'Type at offset ' +
i );
+ assert.equal( data.isOpenElementData( i ), ve.indexOf( i,
isOpen ) !== -1, 'isOpen ' + i );
+ assert.equal( data.isCloseElementData( i ), ve.indexOf( i,
isClose ) !== -1, 'isClose ' + i );
+ }
+} );
+
QUnit.test( 'isElementData', 1, function ( assert ) {
var i,
data = new ve.dm.FlatLinearData( new ve.dm.IndexValueStore(), [
@@ -92,7 +111,3 @@
);
}
} );
-
-// TODO: ve.dm.FlatLinearData#getType
-// TODO: ve.dm.FlatLinearData#isOpenElementData
-// TODO: ve.dm.FlatLinearData#isCloseElementData
--
To view, visit https://gerrit.wikimedia.org/r/100597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a5f2c55928359951c4b811b75662517cec07540
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
