Ottomata has submitted this change and it was merged.

Change subject: Not subscribing varnishkafka to its config files
......................................................................


Not subscribing varnishkafka to its config files

For now, I want to be able to manage varnishkafka restarts manually.

Change-Id: I2aafa3be70837dd41d888c4212b91ddd93b57b11
---
M manifests/role/cache.pp
M modules/varnishkafka
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved



diff --git a/manifests/role/cache.pp b/manifests/role/cache.pp
index 09ac585..47a46a5 100644
--- a/manifests/role/cache.pp
+++ b/manifests/role/cache.pp
@@ -488,6 +488,11 @@
                                queue_buffering_max_messages => 1000000,
                                # large timeout to account for potential cross 
DC latencies
                                topic_request_timeout_ms     => 30000, # 
request ack timeout
+                               # For now, we will not subscribe varnishkafka 
to its
+                               # config files.  Once varnishkafka is deployed 
on a larger
+                               # number of production nodes, we will allow 
puppet
+                               # to restart varnishkafka.
+                               should_subscribe             => false,
                        }
 
                        class { '::varnishkafka::monitoring': }
diff --git a/modules/varnishkafka b/modules/varnishkafka
index fabd3db..448837c 160000
--- a/modules/varnishkafka
+++ b/modules/varnishkafka
-Subproject commit fabd3dbff57637c6b0513a8d6e5f2ee1f7004a8d
+Subproject commit 448837c54d528211a9fb26a30e73ef30e3eb391a

-- 
To view, visit https://gerrit.wikimedia.org/r/101000
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2aafa3be70837dd41d888c4212b91ddd93b57b11
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to