Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/101148
Change subject: Check values property exists before remove attribute
......................................................................
Check values property exists before remove attribute
Apparently the values property is optional so an
exception is thrown if it isn't set.
Bug: 58421
Change-Id: Ied2a1adb2818fb3f516c1cbde263a675ceb84446
---
M modules/ve/dm/ve.dm.Model.js
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/48/101148/1
diff --git a/modules/ve/dm/ve.dm.Model.js b/modules/ve/dm/ve.dm.Model.js
index 31b1677..13a870d 100644
--- a/modules/ve/dm/ve.dm.Model.js
+++ b/modules/ve/dm/ve.dm.Model.js
@@ -279,9 +279,11 @@
function removeAttributeRecursive( children ) {
var i;
for ( i = 0; i < children.length; i++ ) {
- delete children[i].values[attribute];
- if ( ve.isEmptyObject( children[i].values ) ) {
- delete children[i].values;
+ if ( children[i].values ) {
+ delete children[i].values[attribute];
+ if ( ve.isEmptyObject( children[i].values ) ) {
+ delete children[i].values;
+ }
}
if ( children[i].children ) {
removeAttributeRecursive( children[i].children
);
--
To view, visit https://gerrit.wikimedia.org/r/101148
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied2a1adb2818fb3f516c1cbde263a675ceb84446
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
