Zfilipin has submitted this change and it was merged. Change subject: failing on Chrome, need some when_present statements ......................................................................
failing on Chrome, need some when_present statements Change-Id: I36ef567efa5aafdb356df76dbee55e50a3ec9768 --- M features/step_definitions/hotcat_steps.rb 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jhall: Looks good to me, but someone else must approve Zfilipin: Looks good to me, approved diff --git a/features/step_definitions/hotcat_steps.rb b/features/step_definitions/hotcat_steps.rb index f864cae..728bd7f 100644 --- a/features/step_definitions/hotcat_steps.rb +++ b/features/step_definitions/hotcat_steps.rb @@ -14,15 +14,15 @@ end When(/^I click the Categories link$/) do - on(HotcatPage).categories_link + on(HotcatPage).categories_link_element.when_present.click end When(/^I click the Modify several categories button$/) do - on(HotcatPage).modify_several_categories + on(HotcatPage).modify_several_categories_element.when_present.click end Then(/^a Save button is visible$/) do - on(HotcatPage).save_button_element.should be_visible + on(HotcatPage).save_button_element.when_present.should be_visible end Then(/^an Add new categories link is visible$/) do @@ -34,11 +34,11 @@ end Then(/^I can click Cancel and click Add new category$/) do - on(HotcatPage).cancel + on(HotcatPage).cancel_element.when_present.click step "I click the Add a new category link" end Then(/^I can click OK and click Add new category$/) do - on(HotcatPage).ok + on(HotcatPage).ok_element.when_present.click step "I click the Add a new category link" end -- To view, visit https://gerrit.wikimedia.org/r/101211 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36ef567efa5aafdb356df76dbee55e50a3ec9768 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> Gerrit-Reviewer: Jhall <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
