Cmcmahon has submitted this change and it was merged. Change subject: Fix Accept-Language feature[1] for PhantomJS ......................................................................
Fix Accept-Language feature[1] for PhantomJS 1: https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelec tor/blob/master/tests/browser/features/accept_language.feature Bug: 49813 Change-Id: Ib398ef439fda4307b266de03493a8947695a95a4 --- M lib/mediawiki/selenium/env.rb 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/lib/mediawiki/selenium/env.rb b/lib/mediawiki/selenium/env.rb index e6a2f1a..2ea9a22 100644 --- a/lib/mediawiki/selenium/env.rb +++ b/lib/mediawiki/selenium/env.rb @@ -46,13 +46,19 @@ else if browser_label == :firefox profile = Selenium::WebDriver::Firefox::Profile.new + profile["intl.accept_languages"] = language + Watir::Browser.new browser_label, profile: profile elsif browser_label == :chrome profile = Selenium::WebDriver::Chrome::Profile.new + profile["intl.accept_languages"] = language + Watir::Browser.new browser_label, profile: profile + elsif browser_label == :phantomjs + capabilities = Selenium::WebDriver::Remote::Capabilities.phantomjs + capabilities['phantomjs.page.customHeaders.Accept-Language'] = language + Watir::Browser.new browser_label, desired_capabilities: capabilities else - raise "Changing default language is currently supported only for Firefox and Chrome!" + raise "Changing default language is currently supported only for Chrome, Firefox and PhantomJS!" end - profile["intl.accept_languages"] = language - Watir::Browser.new browser_label, :profile => profile end end def sauce_api(json) -- To view, visit https://gerrit.wikimedia.org/r/101213 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib398ef439fda4307b266de03493a8947695a95a4 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/selenium Gerrit-Branch: master Gerrit-Owner: Zfilipin <[email protected]> Gerrit-Reviewer: Amire80 <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: Jhall <[email protected]> Gerrit-Reviewer: KartikMistry <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
