Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/101456


Change subject: JSCS fixes
......................................................................

JSCS fixes

Change-Id: I11032f05eaee1e8c895e06ebbc9c329cbc70c8c0
---
M modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
2 files changed, 3 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/56/101456/1

diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js 
b/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
index 38dc94a..70dd782 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
@@ -83,9 +83,7 @@
 
        // Events
        this.model.connect( this, { 'attributeChange': 'onAttributeChange' } );
-
 };
-
 
 /* Inheritance */
 
@@ -128,7 +126,7 @@
  *  on the rdfaToType object in the model.
  * @returns {Object.<string,string>} A type to Rdfa conversion object
  */
-ve.ce.MWBlockImageNode.prototype.getTypeToRdfa = function() {
+ve.ce.MWBlockImageNode.prototype.getTypeToRdfa = function () {
        var rdfa, obj = {};
 
        for ( rdfa in this.model.constructor.static.rdfaToType ) {
@@ -181,7 +179,7 @@
  * @param {string} to The new alignment
  * @param {string} type The type of the image to which to align
  */
-ve.ce.MWBlockImageNode.prototype.updateAlignment = function( from, to, type ) {
+ve.ce.MWBlockImageNode.prototype.updateAlignment = function ( from, to, type ) 
{
        if ( from !== to ) {
                // remove previous alignment:
                this.$figure
@@ -275,10 +273,9 @@
        ve.ce.BranchNode.prototype.onSetup.call( this );
 
        this.updateAlignment( this.alignment, this.alignment, type );
-       if ( type !== 'none' && type !=='frameless' ) {
+       if ( type !== 'none' && type !== 'frameless' ) {
                this.$element.addClass( this.getCssClass( 'default', 
this.model.getAttribute( 'align' ) ) );
        }
-
 };
 
 /**
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
index c9231ef..7dc7a12 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
@@ -70,7 +70,6 @@
        }
 ];
 
-
 ve.ui.MWMediaEditDialog.static.surfaceCommands = [
        'undo',
        'redo',

-- 
To view, visit https://gerrit.wikimedia.org/r/101456
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11032f05eaee1e8c895e06ebbc9c329cbc70c8c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to