Amire80 has uploaded a new change for review. https://gerrit.wikimedia.org/r/101622
Change subject: Discussion toggle icons for RTL ...................................................................... Discussion toggle icons for RTL Change-Id: I88147962afc06cc23e6b43c9b4e34491b3e955aa --- R modules/base/images/toggle_complete_normal_ltr.png R modules/base/images/toggle_complete_normal_ltr.svg A modules/base/images/toggle_complete_normal_rtl.png A modules/base/images/toggle_complete_normal_rtl.svg R modules/base/images/toggle_complete_selected_ltr.png R modules/base/images/toggle_complete_selected_ltr.svg A modules/base/images/toggle_complete_selected_rtl.png A modules/base/images/toggle_complete_selected_rtl.svg M modules/discussion/styles/collapse.less 9 files changed, 158 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow refs/changes/22/101622/1 diff --git a/modules/base/images/toggle_complete_normal.png b/modules/base/images/toggle_complete_normal_ltr.png similarity index 100% rename from modules/base/images/toggle_complete_normal.png rename to modules/base/images/toggle_complete_normal_ltr.png Binary files differ diff --git a/modules/base/images/toggle_complete_normal.svg b/modules/base/images/toggle_complete_normal_ltr.svg similarity index 100% rename from modules/base/images/toggle_complete_normal.svg rename to modules/base/images/toggle_complete_normal_ltr.svg diff --git a/modules/base/images/toggle_complete_normal_rtl.png b/modules/base/images/toggle_complete_normal_rtl.png new file mode 100644 index 0000000..7b0c121 --- /dev/null +++ b/modules/base/images/toggle_complete_normal_rtl.png Binary files differ diff --git a/modules/base/images/toggle_complete_normal_rtl.svg b/modules/base/images/toggle_complete_normal_rtl.svg new file mode 100644 index 0000000..a5844d5 --- /dev/null +++ b/modules/base/images/toggle_complete_normal_rtl.svg @@ -0,0 +1,71 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<!-- Generator: Adobe Illustrator 16.0.4, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> + +<svg + xmlns:dc="http://purl.org/dc/elements/1.1/"; + xmlns:cc="http://creativecommons.org/ns#"; + xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"; + xmlns:svg="http://www.w3.org/2000/svg"; + xmlns="http://www.w3.org/2000/svg"; + xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"; + xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"; + version="1.1" + id="Layer_1" + x="0px" + y="0px" + width="80px" + height="80px" + viewBox="0 0 80 80" + enable-background="new 0 0 80 80" + xml:space="preserve" + inkscape:version="0.48.4 r9939" + sodipodi:docname="toggle_complete_normal_rtl.svg"><metadata + id="metadata17"><rdf:RDF><cc:Work + rdf:about=""><dc:format>image/svg+xml</dc:format><dc:type + rdf:resource="http://purl.org/dc/dcmitype/StillImage"; /></cc:Work></rdf:RDF></metadata><defs + id="defs15" /><sodipodi:namedview + pagecolor="#ffffff" + bordercolor="#666666" + borderopacity="1" + objecttolerance="10" + gridtolerance="10" + guidetolerance="10" + inkscape:pageopacity="0" + inkscape:pageshadow="2" + inkscape:window-width="640" + inkscape:window-height="480" + id="namedview13" + showgrid="false" + inkscape:zoom="2.95" + inkscape:cx="40" + inkscape:cy="40" + inkscape:window-x="0" + inkscape:window-y="27" + inkscape:window-maximized="0" + inkscape:current-layer="Layer_1" /><g + id="g3" + transform="matrix(-1,0,0,1,80.000001,0)"><rect + x="2.5009999" + y="58.000999" + width="74.998001" + height="18" + id="rect5" + style="fill:#cccccc" /><rect + x="2.5009999" + y="3.9990001" + width="74.998001" + height="18" + id="rect7" + style="fill:#cccccc" /><rect + x="2.5009999" + y="28.083" + width="65.334" + height="8.7480001" + id="rect9" + style="fill:#cccccc" /><rect + x="2.5009999" + y="42.665001" + width="41.169998" + height="9" + id="rect11" + style="fill:#cccccc" /></g></svg> \ No newline at end of file diff --git a/modules/base/images/toggle_complete_selected.png b/modules/base/images/toggle_complete_selected_ltr.png similarity index 100% rename from modules/base/images/toggle_complete_selected.png rename to modules/base/images/toggle_complete_selected_ltr.png Binary files differ diff --git a/modules/base/images/toggle_complete_selected.svg b/modules/base/images/toggle_complete_selected_ltr.svg similarity index 100% rename from modules/base/images/toggle_complete_selected.svg rename to modules/base/images/toggle_complete_selected_ltr.svg diff --git a/modules/base/images/toggle_complete_selected_rtl.png b/modules/base/images/toggle_complete_selected_rtl.png new file mode 100644 index 0000000..9e34f11 --- /dev/null +++ b/modules/base/images/toggle_complete_selected_rtl.png Binary files differ diff --git a/modules/base/images/toggle_complete_selected_rtl.svg b/modules/base/images/toggle_complete_selected_rtl.svg new file mode 100644 index 0000000..0c184df --- /dev/null +++ b/modules/base/images/toggle_complete_selected_rtl.svg @@ -0,0 +1,71 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<!-- Generator: Adobe Illustrator 16.0.4, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> + +<svg + xmlns:dc="http://purl.org/dc/elements/1.1/"; + xmlns:cc="http://creativecommons.org/ns#"; + xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"; + xmlns:svg="http://www.w3.org/2000/svg"; + xmlns="http://www.w3.org/2000/svg"; + xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"; + xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"; + version="1.1" + id="Layer_1" + x="0px" + y="0px" + width="80px" + height="80px" + viewBox="0 0 80 80" + enable-background="new 0 0 80 80" + xml:space="preserve" + inkscape:version="0.48.4 r9939" + sodipodi:docname="toggle_complete_selected_rtl.svg"><metadata + id="metadata17"><rdf:RDF><cc:Work + rdf:about=""><dc:format>image/svg+xml</dc:format><dc:type + rdf:resource="http://purl.org/dc/dcmitype/StillImage"; /></cc:Work></rdf:RDF></metadata><defs + id="defs15" /><sodipodi:namedview + pagecolor="#ffffff" + bordercolor="#666666" + borderopacity="1" + objecttolerance="10" + gridtolerance="10" + guidetolerance="10" + inkscape:pageopacity="0" + inkscape:pageshadow="2" + inkscape:window-width="640" + inkscape:window-height="480" + id="namedview13" + showgrid="false" + inkscape:zoom="2.95" + inkscape:cx="40" + inkscape:cy="40" + inkscape:window-x="0" + inkscape:window-y="27" + inkscape:window-maximized="0" + inkscape:current-layer="Layer_1" /><g + id="g3" + transform="matrix(-1,0,0,1,80.000001,0)"><rect + x="2.5009999" + y="58.000999" + width="74.998001" + height="18" + id="rect5" + style="fill:#777777" /><rect + x="2.5009999" + y="3.9990001" + width="74.998001" + height="18" + id="rect7" + style="fill:#777777" /><rect + x="2.5009999" + y="28.083" + width="65.334" + height="8.7480001" + id="rect9" + style="fill:#777777" /><rect + x="2.5009999" + y="42.665001" + width="41.169998" + height="9" + id="rect11" + style="fill:#777777" /></g></svg> \ No newline at end of file diff --git a/modules/discussion/styles/collapse.less b/modules/discussion/styles/collapse.less index dfee9c5..569c29a 100644 --- a/modules/discussion/styles/collapse.less +++ b/modules/discussion/styles/collapse.less @@ -7,7 +7,21 @@ .background-image-svg( ~"@{icon-prefix}_selected.svg", ~"@{icon-prefix}_selected.png" ); } - background-position: 16px !important; + .collapseButtonBackground() +} + +.collapseButtonIconBidi(@icon-prefix) { + .background-image-svg( ~"@{icon-prefix}_normal_ltr.svg", ~"@{icon-prefix}_normal_ltr.png" ); + + &.active { + .background-image-svg( ~"@{icon-prefix}_selected_ltr.svg", ~"@{icon-prefix}_selected_ltr.png" ); + } + + .collapseButtonBackground() +} + +.collapseButtonBackground() { + background-position: left 16px center !important; background-size: 14px auto !important; background-repeat: no-repeat !important; } @@ -34,7 +48,7 @@ } .topic-complete { - .collapseButtonIcon( '../../base/images/toggle_complete' ); + .collapseButtonIconBidi( '../../base/images/toggle_complete' ); } } -- To view, visit https://gerrit.wikimedia.org/r/101622 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I88147962afc06cc23e6b43c9b4e34491b3e955aa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
