IAlex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/101650
Change subject: Use a better regular expression to find documented hooks in
findHooks.php
......................................................................
Use a better regular expression to find documented hooks in findHooks.php
Added a ":" after the second quote so that only strings in the form
'Hook': are matched, otherwise the line 1172 of hooks.txt provoques the
the following message:
Documented and not found: value
because the line starts with 'value'.
Change-Id: I1d603e3fa10dcabf25e31f6a71aad233571738b5
---
M maintenance/findHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/50/101650/1
diff --git a/maintenance/findHooks.php b/maintenance/findHooks.php
index a936436..24b23d9 100644
--- a/maintenance/findHooks.php
+++ b/maintenance/findHooks.php
@@ -142,7 +142,7 @@
private function getHooksFromLocalDoc( $doc ) {
$m = array();
$content = file_get_contents( $doc );
- preg_match_all( "/\n'(.*?)'/", $content, $m );
+ preg_match_all( "/\n'(.*?)':/", $content, $m );
return array_unique( $m[1] );
}
--
To view, visit https://gerrit.wikimedia.org/r/101650
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d603e3fa10dcabf25e31f6a71aad233571738b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <coderev...@emsenhuber.ch>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
