Merlijn van Deen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/101783


Change subject: i18n: Allow empty translations
......................................................................

i18n: Allow empty translations

Check for 'trans is None' (= no translation found) instead of
for 'not trans' (= no translation found, or empty translation)

Can be relevant for empty configuration variables.

Change-Id: Icf8ca6a76d1fdcbe7be3a4ac276a5e9d0688108b
---
M pywikibot/i18n.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/83/101783/1

diff --git a/pywikibot/i18n.py b/pywikibot/i18n.py
index 8e818eb..ac2c0f6 100644
--- a/pywikibot/i18n.py
+++ b/pywikibot/i18n.py
@@ -362,7 +362,7 @@
                 break
             except KeyError:
                 continue
-        if not trans:
+        if trans is None:
             raise TranslationError("No English translation has been defined "
                                    "for TranslateWiki key %r" % twtitle)
     # send the language code back via the given list

-- 
To view, visit https://gerrit.wikimedia.org/r/101783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf8ca6a76d1fdcbe7be3a4ac276a5e9d0688108b
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Merlijn van Deen <valhall...@arctus.nl>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to