jenkins-bot has submitted this change and it was merged.
Change subject: Add debug logging for bug 57464
......................................................................
Add debug logging for bug 57464
Currently any namespace that is equal to an interwiki
prefix on the submission site is mysteriously dropped.
1dd6eab3578 should have fixed this, but it didn't.
If the debug statements show that the interwiki prefix
is still retained after a new Title object is created,
we will know that the previous fix was inadequate.
If not, something else is terribly wrong.
Bug: 57464
Change-Id: Iec240623ae73b647ed700fb5ce0ff3277152ddc7
(cherry picked from commit 8d28ff418e7b20fa129528072041ec655c5cf517)
---
M MassMessageJob.php
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MassMessageJob.php b/MassMessageJob.php
index 07d9414..670bfac 100644
--- a/MassMessageJob.php
+++ b/MassMessageJob.php
@@ -13,10 +13,14 @@
class MassMessageJob extends Job {
public function __construct( Title $title, array $params, $id = 0 ) {
parent::__construct( 'MassMessageJob', $title, $params, $id );
+ // More debug logging for bug 57464
+ wfDebugLog( 'MassMessage', "Before re-normalizing, title is
\"{$this->title->getPrefixedText()}\", "
+ . "interwiki is \"{$this->title->getInterwiki()}\", ns
is \"{$this->title->getNamespace()}\"" );
// Create a fresh Title object so namespaces are evaluated
// in the context of the target site. Bug 57464
$this->title = Title::newFromText(
$this->title->getPrefixedText() );
-
+ wfDebugLog( 'MassMessage', "After re-normalizing, title is
\"{$this->title->getPrefixedText()}\", "
+ . "interwiki is \"{$this->title->getInterwiki()}\", ns
is \"{$this->title->getNamespace()}\"" );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/101810
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec240623ae73b647ed700fb5ce0ff3277152ddc7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: 1.23wmf6
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
