Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/102042
Change subject: Update zero sandbox requests scenarios
......................................................................
Update zero sandbox requests scenarios
* Update the 'Searching for languages to which nobody translates'
scenario to reflect its title.
* Hide the "older requests" link when no users are found by language.
* Update the scenario of no user requests.
Change-Id: I765372bd43b5a9b0b2dca98bf6fa865a49a5923e
---
M resources/js/ext.translate.special.translatesandbox.js
M tests/browser/features/manage_translator_sandbox.feature
2 files changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/42/102042/1
diff --git a/resources/js/ext.translate.special.translatesandbox.js
b/resources/js/ext.translate.special.translatesandbox.js
index 0f38e71..627f59e 100644
--- a/resources/js/ext.translate.special.translatesandbox.js
+++ b/resources/js/ext.translate.special.translatesandbox.js
@@ -473,6 +473,7 @@
.text( $.uls.data.getAutonym( language
) );
filterRequestsByLanguage( language );
+ indicateOlderRequests();
$clearLanguageSelector.removeClass( 'hide' );
},
diff --git a/tests/browser/features/manage_translator_sandbox.feature
b/tests/browser/features/manage_translator_sandbox.feature
index e017f5c..f37dcdb 100644
--- a/tests/browser/features/manage_translator_sandbox.feature
+++ b/tests/browser/features/manage_translator_sandbox.feature
@@ -16,7 +16,10 @@
Scenario: There are no users in the sandbox
Given I am on the Translator sandbox management page with no users in the
sandbox
Then no users are displayed in the first column
+ And I should see '0 requests' at the top of the first column
+ And I should see '0 users selected' at the bottom of the first column
And I should see 'No requests from new users' in the second column
+ And I should not see the older requests link at the bottom of the first
column
Scenario: Existing users can be searched on the list
Given I am on the Translator sandbox management page with users in the
sandbox
@@ -104,13 +107,10 @@
Given I am on the Translator sandbox management page with users in the
sandbox
When I click the sandboxed users language filter button
And I type 'be' in the language filter
- And I click the button that clears language selection
- Then I should see the checkbox next to the request from 'Kissa' checked
- And I should see the checkbox next to the request from 'Kissa' disabled
- And I should see '11 requests' at the top of the first column
- And I should see '1 user selected' at the bottom of the first column
- And I should not see the button that clears language selection
- And usernames are visible in the first column
+ Then no users are displayed in the first column
+ And I should see '0 requests' at the top of the first column
+ And I should see '0 users selected' at the bottom of the first column
+ And I should not see the older requests link at the bottom of the first
column
Scenario: Translation Administrator should be able to see a list of pending
requests with usernames in the first column, sorted by the number of
translations and the most recent within them, and the first user should be
selected
Given I am on the Translator sandbox management page with users in the
sandbox
--
To view, visit https://gerrit.wikimedia.org/r/102042
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I765372bd43b5a9b0b2dca98bf6fa865a49a5923e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
