Reedy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/102319
Change subject: Return value in UploadMetadataJob::recreateMetadataJob()
......................................................................
Return value in UploadMetadataJob::recreateMetadataJob()
Change-Id: I0c8dce819e80a64c9a37b3ca9cb61a65a01a9c44
---
M includes/Jobs/UploadMetadataJob.php
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GWToolset
refs/changes/19/102319/1
diff --git a/includes/Jobs/UploadMetadataJob.php
b/includes/Jobs/UploadMetadataJob.php
index 125f6f7..b03f132 100644
--- a/includes/Jobs/UploadMetadataJob.php
+++ b/includes/Jobs/UploadMetadataJob.php
@@ -63,8 +63,6 @@
* @return {bool}
*/
protected function recreateMetadataJob() {
- $result = false;
-
if ( (int)$this->params['attempts'] >
(int)Config::$metadata_job_max_attempts ) {
$job_release =
isset( $this->params['jobReleaseTimestamp'] )
@@ -109,7 +107,7 @@
);
}
- $result = JobQueueGroup::singleton()->push( $job );
+ return JobQueueGroup::singleton()->push( $job );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/102319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c8dce819e80a64c9a37b3ca9cb61a65a01a9c44
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
