Dan-nl has submitted this change and it was merged.
Change subject: Remove unused imports
......................................................................
Remove unused imports
Change-Id: I93ff9582ca15c8ac87279bddf16983a9571e5a23
---
M includes/Adapters/Php/MappingPhpAdapter.php
M includes/Adapters/Php/MediawikiTemplatePhpAdapter.php
M includes/Forms/MetadataMappingForm.php
M includes/Forms/PreviewForm.php
M includes/GWTException.php
M includes/Handlers/Forms/FormHandler.php
M includes/Handlers/Forms/MetadataDetectHandler.php
M includes/Handlers/Forms/MetadataMappingHandler.php
M includes/Handlers/UploadHandler.php
M includes/Handlers/Xml/XmlDetectHandler.php
M includes/Handlers/Xml/XmlHandler.php
M includes/Handlers/Xml/XmlMappingHandler.php
M includes/Helpers/FileChecks.php
M includes/Helpers/GWTFileBackend.php
M includes/Helpers/WikiChecks.php
M includes/Models/Mapping.php
M includes/Models/MediawikiTemplate.php
M includes/Models/ModelInterface.php
M includes/Php/File.php
M includes/Specials/SpecialGWToolset.php
M includes/Utils.php
M maintenance/cleanupGWTFileBackend.php
22 files changed, 21 insertions(+), 76 deletions(-)
Approvals:
Dan-nl: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Adapters/Php/MappingPhpAdapter.php
b/includes/Adapters/Php/MappingPhpAdapter.php
index 6558d94..839cefb 100644
--- a/includes/Adapters/Php/MappingPhpAdapter.php
+++ b/includes/Adapters/Php/MappingPhpAdapter.php
@@ -10,7 +10,6 @@
namespace GWToolset\Adapters\Php;
use GWToolset\Adapters\DataAdapterInterface,
GWToolset\GWTException,
- Revision,
Title,
WikiPage;
diff --git a/includes/Adapters/Php/MediawikiTemplatePhpAdapter.php
b/includes/Adapters/Php/MediawikiTemplatePhpAdapter.php
index 321ac4e..1a64b4a 100644
--- a/includes/Adapters/Php/MediawikiTemplatePhpAdapter.php
+++ b/includes/Adapters/Php/MediawikiTemplatePhpAdapter.php
@@ -14,9 +14,6 @@
GWToolset\Config,
GWToolset\GWTException,
GWToolset\Utils,
- MimeMagic,
- MWException,
- MWHttpRequest,
Title;
class MediawikiTemplatePhpAdapter implements DataAdapterInterface {
diff --git a/includes/Forms/MetadataMappingForm.php
b/includes/Forms/MetadataMappingForm.php
index 3b299f1..3933fa7 100644
--- a/includes/Forms/MetadataMappingForm.php
+++ b/includes/Forms/MetadataMappingForm.php
@@ -11,8 +11,6 @@
GWToolset\Config,
GWToolset\Utils,
GWToolset\Handlers\Forms\FormHandler,
- GWToolset\Helpers\FileChecks,
- IContextSource,
Linker,
Title;
diff --git a/includes/Forms/PreviewForm.php b/includes/Forms/PreviewForm.php
index 5ec8a1f..9f97ffb 100644
--- a/includes/Forms/PreviewForm.php
+++ b/includes/Forms/PreviewForm.php
@@ -9,7 +9,6 @@
namespace GWToolset\Forms;
use GWToolset\Config,
GWToolset\Utils,
- GWToolset\Helpers\FileChecks,
Html,
IContextSource,
Linker,
diff --git a/includes/GWTException.php b/includes/GWTException.php
index be4dc38..0ebffda 100644
--- a/includes/GWTException.php
+++ b/includes/GWTException.php
@@ -8,8 +8,7 @@
*/
namespace GWToolset;
-use Exception,
- GWToolset\Utils;
+use Exception;
class GWTException extends Exception {
diff --git a/includes/Handlers/Forms/FormHandler.php
b/includes/Handlers/Forms/FormHandler.php
index 4eb0bd5..137ea10 100644
--- a/includes/Handlers/Forms/FormHandler.php
+++ b/includes/Handlers/Forms/FormHandler.php
@@ -8,11 +8,9 @@
*/
namespace GWToolset\Handlers\Forms;
use GWToolset\GWTException,
- GWToolset\Utils,
GWToolset\Helpers\WikiChecks,
Html,
- MWException,
- SpecialPage;
+ MWException;
abstract class FormHandler {
diff --git a/includes/Handlers/Forms/MetadataDetectHandler.php
b/includes/Handlers/Forms/MetadataDetectHandler.php
index fdcbac1..5abc289 100644
--- a/includes/Handlers/Forms/MetadataDetectHandler.php
+++ b/includes/Handlers/Forms/MetadataDetectHandler.php
@@ -12,8 +12,6 @@
GWToolset\Adapters\Php\MediawikiTemplatePhpAdapter,
GWToolset\Config,
GWToolset\Forms\MetadataMappingForm,
- GWToolset\GWTException,
- GWToolset\Handlers\Forms\FormHandler,
GWToolset\Handlers\UploadHandler,
GWToolset\Handlers\Xml\XmlDetectHandler,
GWToolset\Helpers\GWTFileBackend,
diff --git a/includes/Handlers/Forms/MetadataMappingHandler.php
b/includes/Handlers/Forms/MetadataMappingHandler.php
index d9122c0..98a5504 100644
--- a/includes/Handlers/Forms/MetadataMappingHandler.php
+++ b/includes/Handlers/Forms/MetadataMappingHandler.php
@@ -16,8 +16,6 @@
GWToolset\Constants,
GWToolset\Utils,
GWToolset\Forms\PreviewForm,
- GWToolset\GWTException,
- GWToolset\Handlers\Forms\FormHandler,
GWToolset\Handlers\UploadHandler,
GWToolset\Handlers\Xml\XmlMappingHandler,
GWToolset\Helpers\GWTFileBackend,
@@ -29,9 +27,7 @@
JobQueueGroup,
Linker,
MWException,
- SpecialPage,
- Title,
- User;
+ Title;
class MetadataMappingHandler extends FormHandler {
diff --git a/includes/Handlers/UploadHandler.php
b/includes/Handlers/UploadHandler.php
index d04fe40..e3e6825 100644
--- a/includes/Handlers/UploadHandler.php
+++ b/includes/Handlers/UploadHandler.php
@@ -13,22 +13,15 @@
GWToolset\Constants,
GWToolset\GWTException,
GWToolset\Utils,
- GWToolset\Helpers\GWTFileBackend,
GWToolset\Helpers\FileChecks,
GWToolset\Helpers\WikiChecks,
GWToolset\Jobs\UploadMediafileJob,
- GWToolset\Models\Mapping,
- GWToolset\Models\MediawikiTemplate,
- GWToolset\Models\Metadata,
- JobQueueGroup,
MimeMagic,
MWException,
MWHttpRequest,
- Php\File,
Title,
UploadBase,
UploadFromUrl,
- User,
WikiPage;
class UploadHandler {
diff --git a/includes/Handlers/Xml/XmlDetectHandler.php
b/includes/Handlers/Xml/XmlDetectHandler.php
index 1950090..71e42f9 100644
--- a/includes/Handlers/Xml/XmlDetectHandler.php
+++ b/includes/Handlers/Xml/XmlDetectHandler.php
@@ -8,17 +8,15 @@
*/
namespace GWToolset\Handlers\Xml;
-use Content,
- DOMElement,
+use
+DOMElement,
GWToolset\GWTException,
- GWToolset\Helpers\GWTFileBackend,
GWToolset\Utils,
GWToolset\Models\Mapping,
GWToolset\Models\MediawikiTemplate,
Html,
MWException,
Sanitizer,
- SpecialPage,
XMLReader;
/**
diff --git a/includes/Handlers/Xml/XmlHandler.php
b/includes/Handlers/Xml/XmlHandler.php
index ed3f749..0fbda39 100644
--- a/includes/Handlers/Xml/XmlHandler.php
+++ b/includes/Handlers/Xml/XmlHandler.php
@@ -8,13 +8,9 @@
*/
namespace GWToolset\Handlers\Xml;
-use Content,
- DOMDocument,
- DOMXPath,
- GWToolset\GWTException,
- GWToolset\Utils,
+use
+GWToolset\GWTException,
Html,
- Linker,
MWException,
XMLReader;
diff --git a/includes/Handlers/Xml/XmlMappingHandler.php
b/includes/Handlers/Xml/XmlMappingHandler.php
index 614b999..71b1306 100644
--- a/includes/Handlers/Xml/XmlMappingHandler.php
+++ b/includes/Handlers/Xml/XmlMappingHandler.php
@@ -8,15 +8,11 @@
*/
namespace GWToolset\Handlers\Xml;
-use Content,
- DOMElement,
+use
+DOMElement,
GWToolset\Config,
- GWToolset\Helpers\GWTFileBackend,
GWToolset\Utils,
- GWToolset\Models\Mapping,
- GWToolset\Models\MediawikiTemplate,
MWException,
- SpecialPage,
XMLReader;
class XmlMappingHandler extends XmlHandler {
diff --git a/includes/Helpers/FileChecks.php b/includes/Helpers/FileChecks.php
index 0c966c6..f42030a 100644
--- a/includes/Helpers/FileChecks.php
+++ b/includes/Helpers/FileChecks.php
@@ -14,7 +14,6 @@
MimeMagic,
MWException,
Php\File,
- OutputPage,
Status,
UploadBase;
diff --git a/includes/Helpers/GWTFileBackend.php
b/includes/Helpers/GWTFileBackend.php
index 997c324..6bb632a 100644
--- a/includes/Helpers/GWTFileBackend.php
+++ b/includes/Helpers/GWTFileBackend.php
@@ -10,7 +10,6 @@
namespace GWToolset\Helpers;
use FileBackendGroup,
GWToolset\Jobs\GWTFileBackendCleanupJob,
- GWToolset\Config,
GWToolset\Constants,
GWToolset\Utils,
JobQueueGroup,
diff --git a/includes/Helpers/WikiChecks.php b/includes/Helpers/WikiChecks.php
index 56e8386..19dae44 100644
--- a/includes/Helpers/WikiChecks.php
+++ b/includes/Helpers/WikiChecks.php
@@ -11,13 +11,10 @@
use GWToolset\Config,
GWToolset\Constants,
GWToolset\Utils,
- Html,
MWException,
PermissionsError,
SpecialPage,
- Status,
- User,
- UserBlockedError;
+ Status;
/**
* provides several methods for verifying :
diff --git a/includes/Models/Mapping.php b/includes/Models/Mapping.php
index a61c819..4324398 100644
--- a/includes/Models/Mapping.php
+++ b/includes/Models/Mapping.php
@@ -12,9 +12,7 @@
GWtoolset\Config,
GWToolset\GWTException,
GWToolset\Utils,
- GWToolset\Helpers\FileChecks,
GWToolset\Helpers\WikiPages,
- Language,
Linker;
class Mapping implements ModelInterface {
diff --git a/includes/Models/MediawikiTemplate.php
b/includes/Models/MediawikiTemplate.php
index 8df46f6..a496929 100644
--- a/includes/Models/MediawikiTemplate.php
+++ b/includes/Models/MediawikiTemplate.php
@@ -13,11 +13,7 @@
GWToolset\Config,
GWToolset\GWTException,
GWToolset\Utils,
- GWToolset\Helpers\FileChecks,
- MWException,
- ReflectionClass,
- ReflectionProperty,
- ResultWrapper;
+ MWException;
class MediawikiTemplate implements ModelInterface {
diff --git a/includes/Models/ModelInterface.php
b/includes/Models/ModelInterface.php
index 3b4bfba..b5bf5bc 100644
--- a/includes/Models/ModelInterface.php
+++ b/includes/Models/ModelInterface.php
@@ -7,7 +7,7 @@
* @license GNU General Public License 3.0 http://www.gnu.org/licenses/gpl.html
*/
namespace GWToolset\Models;
-use ResultWrapper;
+
interface ModelInterface {
diff --git a/includes/Php/File.php b/includes/Php/File.php
index 72d29d4..3a5aacd 100644
--- a/includes/Php/File.php
+++ b/includes/Php/File.php
@@ -8,8 +8,8 @@
*/
namespace Php;
-use finfo,
- GWToolset\GWTException,
+use
+GWToolset\GWTException,
GWToolset\Utils,
MimeMagic,
MWException;
diff --git a/includes/Specials/SpecialGWToolset.php
b/includes/Specials/SpecialGWToolset.php
index a9d6168..085665b 100644
--- a/includes/Specials/SpecialGWToolset.php
+++ b/includes/Specials/SpecialGWToolset.php
@@ -8,16 +8,13 @@
*/
namespace GWToolset;
-use GWToolset\Constants,
- GWToolset\GWTException,
- GWToolset\Utils,
- GWToolset\Handlers\Forms\FormHandler,
+use
+GWToolset\Handlers\Forms\FormHandler,
GWToolset\Helpers\FileChecks,
GWToolset\Helpers\WikiChecks,
Html,
Linker,
MWException,
- PermissionsError,
SpecialPage,
Title;
diff --git a/includes/Utils.php b/includes/Utils.php
index 03d48f1..823b6bc 100644
--- a/includes/Utils.php
+++ b/includes/Utils.php
@@ -8,19 +8,11 @@
*/
namespace GWToolset;
-use ErrorException,
- GWToolset\Config,
- GWToolset\GWTException,
- GWToolset\Utils,
- GWToolset\MediaWiki\Api\Client,
- Html,
+use
+GWToolset\MediaWiki\Api\Client,
Language,
MWException,
- SpecialPage,
- Status,
- Title,
- RecursiveArrayIterator,
- RecursiveIteratorIterator;
+ Title;
class Utils {
diff --git a/maintenance/cleanupGWTFileBackend.php
b/maintenance/cleanupGWTFileBackend.php
index 4437543..b08dc80 100644
--- a/maintenance/cleanupGWTFileBackend.php
+++ b/maintenance/cleanupGWTFileBackend.php
@@ -8,8 +8,8 @@
*/
namespace GWToolset;
-use GWToolset\Config,
- GWToolset\Helpers\GWTFileBackend,
+use
+GWToolset\Helpers\GWTFileBackend,
Maintenance,
MWException;
--
To view, visit https://gerrit.wikimedia.org/r/102321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93ff9582ca15c8ac87279bddf16983a9571e5a23
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Dan-nl <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
