jenkins-bot has submitted this change and it was merged. Change subject: Fix "Emptying the search field shows all the users" ......................................................................
Fix "Emptying the search field shows all the users" Emptying the field was not triggering our JavaScript bindings. Added a workaround. Change-Id: I1a9c477d1d8df0edb99e4446f0947e48f0e4daa5 --- M tests/browser/features/step_definitions/manage_translator_sandbox_steps.rb 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/manage_translator_sandbox_steps.rb b/tests/browser/features/step_definitions/manage_translator_sandbox_steps.rb index b7b3dc9..a8b98b7 100644 --- a/tests/browser/features/step_definitions/manage_translator_sandbox_steps.rb +++ b/tests/browser/features/step_definitions/manage_translator_sandbox_steps.rb @@ -11,7 +11,10 @@ end When(/^I search for "(.*)" in the sandboxed users search field$/) do |string| - on(ManageTranslatorSandboxPage).search = string + on(ManageTranslatorSandboxPage) do |page| + page.search = string + page.search_element.send_keys :enter + end end When(/^I click the sandboxed users language filter button$/) do -- To view, visit https://gerrit.wikimedia.org/r/102415 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a9c477d1d8df0edb99e4446f0947e48f0e4daa5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit <[email protected]> Gerrit-Reviewer: Amire80 <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
