Dzahn has submitted this change and it was merged.

Change subject: Remove intro hook <div> from global footer
......................................................................


Remove intro hook <div> from global footer

I have no idea why this is here, but an "intro" hook (which we
don't use) at the bottom of the page feels wrong (should be rather
for the "outro" hook) plus breaks CSS when expanding the page-index
div (tested on boogs.wmflabs.org) with more content.
The "intro" hook still exists at the top of the frontpage (where
it should be).

Change-Id: I0e9827db64378246147f7d358495d7f8fc8e4ee2
---
M template/en/custom/global/footer.html.tmpl
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Aklapper: Looks good to me, but someone else must approve
  Dzahn: Verified; Looks good to me, approved



diff --git a/template/en/custom/global/footer.html.tmpl 
b/template/en/custom/global/footer.html.tmpl
index 3070944..bea9135 100644
--- a/template/en/custom/global/footer.html.tmpl
+++ b/template/en/custom/global/footer.html.tmpl
@@ -110,7 +110,6 @@
 
                <!-- footer -->
                <div id="footer" >
-                       <div class="intro">[% Hook.process('intro') %]</div>
                        <ul id="footer-info">
                                <li>Bugzilla version [%+ 
constants.BUGZILLA_VERSION FILTER html %]</li>
                        </ul>

-- 
To view, visit https://gerrit.wikimedia.org/r/101655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e9827db64378246147f7d358495d7f8fc8e4ee2
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/bugzilla/modifications
Gerrit-Branch: master
Gerrit-Owner: Aklapper <[email protected]>
Gerrit-Reviewer: Aklapper <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to