Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/102548
Change subject: Don't use hard coded Item ids in SetClaimTest
......................................................................
Don't use hard coded Item ids in SetClaimTest
Change-Id: I594697c0f8f118dcb80962ac02fb6d871879ee61
---
M repo/tests/phpunit/includes/api/SetClaimTest.php
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/48/102548/1
diff --git a/repo/tests/phpunit/includes/api/SetClaimTest.php
b/repo/tests/phpunit/includes/api/SetClaimTest.php
index 4a518d8..ed94dbd 100644
--- a/repo/tests/phpunit/includes/api/SetClaimTest.php
+++ b/repo/tests/phpunit/includes/api/SetClaimTest.php
@@ -7,8 +7,6 @@
use Wikibase\Claims;
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Entity\EntityId;
-use Wikibase\DataModel\Entity\ItemId;
-use Wikibase\Property;
use Wikibase\PropertyContent;
use Wikibase\Lib\Serializers\SerializerFactory;
use Wikibase\Repo\WikibaseRepo;
@@ -171,16 +169,15 @@
public function testSetClaimAtIndex( Claim $claim ) {
// Generate an item with some claims:
$item = Item::newEmpty();
- $item->setId( ItemId::newFromNumber( 906054 ) );
- $guidGenerator = new ClaimGuidGenerator( $item->getId() );
-
$claims = new Claims();
- // (Re-)initialize item content with empty claims:
+ // Initialize item content with empty claims:
$item->setClaims( $claims );
$content = new ItemContent( $item );
$content->save( 'setclaimtest', null, EDIT_NEW );
+ $guidGenerator = new ClaimGuidGenerator( $item->getId() );
+
for( $i = 1; $i <= 3; $i++ ) {
$preexistingClaim = $item->newClaim( new
PropertyNoValueSnak( $i ) );
$preexistingClaim->setGuid( $guidGenerator->newGuid() );
--
To view, visit https://gerrit.wikimedia.org/r/102548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I594697c0f8f118dcb80962ac02fb6d871879ee61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
