Reedy has submitted this change and it was merged.
Change subject: Add logging for "Invalid message parameter"
......................................................................
Add logging for "Invalid message parameter"
Records a full stacktrace for this warning
Bug: 58676
Change-Id: I234b525b04168eee6085d44fbf0e0d8ac3d0af91
(cherry picked from commit aa8873e2b951a8ff8c4f30ba114fda76d090846c)
---
M includes/Message.php
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Reedy: Verified; Looks good to me, approved
diff --git a/includes/Message.php b/includes/Message.php
index 6ac87b3..dd22844 100644
--- a/includes/Message.php
+++ b/includes/Message.php
@@ -817,11 +817,12 @@
} elseif ( isset( $param['bitrate'] ) ) {
return array( 'before',
$this->language->formatBitrate( $param['bitrate'] ) );
} else {
- trigger_error(
- 'Invalid parameter for message "' .
$this->getKey() . '": ' .
- htmlspecialchars( serialize( $param ) ),
- E_USER_WARNING
- );
+ $warning = 'Invalid parameter for message "' .
$this->getKey() . '": ' .
+ htmlspecialchars( serialize( $param ) );
+ trigger_error( $warning, E_USER_WARNING );
+ $e = new Exception;
+ wfDebugLog( 'Bug58676', $warning . "\n" .
$e->getTraceAsString() );
+
return array( 'before', '[INVALID]' );
}
} elseif ( $param instanceof Message ) {
--
To view, visit https://gerrit.wikimedia.org/r/102741
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I234b525b04168eee6085d44fbf0e0d8ac3d0af91
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.23wmf7
Gerrit-Owner: Reedy <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: Yurik <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
