Kaldari has submitted this change and it was merged. Change subject: More maintenance for CentralNotice extension. ......................................................................
More maintenance for CentralNotice extension. * Deglobalisation. * Made SpecialBannerAllocation, SpecialBannerListLoader, SpecialCentralNoticeLogs and SpecialNoticeTemplate extend CentralNotice, moved some methods to CentralNotice and removed static usage. * Replaced deprecated methods. * Remove superfluous checks for MEDIAWIKI constant. * Change dirname( __FILE__ ) to __DIR__. * Combined some border CSS properties. * Updated parameters to use correct types. * Some trailing whitespace and superfluous newlines removed. Patchset 4: Fixing banner delivery with a partial revert Change-Id: I8ed85e5ddeaf7a98661802740eef4ce3002e18a7 --- M CentralNotice.db.php M CentralNotice.php M CentralNoticeBannerLogPager.php M CentralNoticeCampaignLogPager.php M CentralNoticePageLogPager.php M TemplatePager.php M modules/ext.centralNotice.interface/centralnotice.css M special/SpecialBannerAllocation.php M special/SpecialBannerListLoader.php M special/SpecialBannerLoader.php M special/SpecialCentralNotice.php M special/SpecialCentralNoticeLogs.php M special/SpecialHideBanners.php M special/SpecialNoticeTemplate.php 14 files changed, 375 insertions(+), 389 deletions(-) Approvals: Kaldari: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/22887 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ed85e5ddeaf7a98661802740eef4ce3002e18a7 Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Siebrand <[email protected]> Gerrit-Reviewer: Adamw <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: Mwalker <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: Pgehres <[email protected]> Gerrit-Reviewer: Siebrand <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
