Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/103099
Change subject: Make sure the overlay is visible, even if the badge is near the
edge
......................................................................
Make sure the overlay is visible, even if the badge is near the edge
We just shift it a bit to fit it on the screen.
Bug: 58728
Change-Id: I61847ed7b9f08ce6618a903bb4f5e0d6afb07e9b
---
M modules/overlay/ext.echo.overlay.js
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/99/103099/1
diff --git a/modules/overlay/ext.echo.overlay.js
b/modules/overlay/ext.echo.overlay.js
index 6b46223..0f24c0c 100644
--- a/modules/overlay/ext.echo.overlay.js
+++ b/modules/overlay/ext.echo.overlay.js
@@ -301,6 +301,19 @@
// Show the notifications overlay
$overlay.show();
+
+ // Make sure the overlay is visible,
even if the badge is near the edge of browser window.
+ // 10 is an arbitrarily chosen "close
enough" number.
+ // We are careful not to slide out from
below the pokey (which is 21px wide).
+ var
+ offset = $overlay.offset(),
+ width = $overlay.width(),
+ windowWidth = $( window
).width();
+ if ( offset.left < 10 ) {
+ $overlay.css( 'left', '+=' +
Math.min( 189, 10 - offset.left ) );
+ } else if ( offset.left + width >
windowWidth - 10 ) {
+ $overlay.css( 'left', '-=' +
Math.min( 189, ( offset.left + width ) - ( windowWidth - 10 ) ) );
+ }
}
);
} );
--
To view, visit https://gerrit.wikimedia.org/r/103099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61847ed7b9f08ce6618a903bb4f5e0d6afb07e9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
